Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds API-3
open_mart(textConstant)using native screen factories and transactions on Gen1–3.Preflight validates every map/text stock entry, including entries after a warp, plus item IDs/prices and wallet/inventory stores. Dispatch checks again. Native classic lists, quantity selectors, confirmations, FireRed's inline quantity and Emerald's sell bag retain their normal behavior. Screen/phase callback leases prevent cancelled, closed, superseded or retired callbacks from replaying purchases; foreign overlays pause effects. Changed inventories/item prices or retired constructors cannot leave a stale transaction/root behind. Committed native transactions are retained on cancellation.
Dependency: merge #116 and prerequisites first. Focused change 089a4c9…1a09b6c.
Validation at clean head
1a09b6c7847a723805fd39e88ea0be17f5dc7795:79ea62f45fb2ea8f65d081a109431e4eb1bbdb36, including native shop open/close and continuation across eight versions.0f35bc8f68bb21789b31091ecd3595dc4acebefb: 96/106 engine suites, SDK 3/3, B30 and 144/288 cross-engine checks.Tests are ROM-free; shared checks use real native shop implementations with fixture stock/font/greeting data. Native purchases/sales are exercised locally in this host; no ROM gameplay or pixel/audio equivalence claim. Missing native mart entries are refused rather than inferred from unrelated ROM pointers. Price/count/size and exact-integer limits are documented.
Hosted Actions: API 3 contracts and ci are
action_required(fork workflow approval). Hosted tests have not run; the results above are local.