Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds portable API-3
start_battle("trainer", trainerRef, partyIndex?)using this host's native trainer constructor, entry and cleanup paths.Preflight and dispatch validate the selected roster, species/levels, native class aliases and Gen3 trainer/flag metadata. Numeric Gen2 classes resolve to canonical host class records; Gen3 numbers resolve through trainerOrder. Ambiguous/missing references are refused rather than guessed from display names. Gen3 wins reuse the native victory-flag and Match Call helpers. Same-session native cleanup survives mod retirement, while stale script continuations cannot run later effects.
Dependency: merge #115 and prerequisites first. Focused change 7f46d4d…089a4c9.
Validation at clean head
089a4c9c1dbdbbbd65fd02bee19ad3af3f356d00:79ea62f45fb2ea8f65d081a109431e4eb1bbdb36.9a978d5f4302aed6748c2092d4ceee3666013b25: 95/105 engine suites, SDK 3/3, B30 and 136/272 cross-engine checks.Trainer selectors remain game-specific. Use a native trainer number for shared Gen3 scripts; display names are not treated as reference constant aliases. Use an explicit member index in shared Gen2 scripts because the pinned reference requires it. Tests are ROM-free with native data/entry seams; no ROM gameplay, story-reward or pixel equivalence claim.
Hosted Actions: API 3 contracts and ci are
action_required(fork workflow approval). Hosted tests have not run; the results above are local.