Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds API-3
start_battle("wild", speciesId, level),static_battle(speciesId, level, beatFlag?)andcheck_battle_result(...)on Gen1–3.Whole-program preflight resolves canonical species and optional beat flags before any prefix runs. A private owned-script admission guard reuses the public encounter adapter's native construction, transition and afterBattle cleanup without relaxing ordinary public admission. Static encounters set their beat flag and hide the talking NPC on win/catch/flee, and skip both on loss. Results can drive portable conditional jumps.
Cancellation leaves native battle screens and same-session cleanup intact while retiring the script continuation. Changed sessions, native failures, cleanup errors, unloads during construction, replayed callbacks and foreign overlays cannot run later script effects.
Dependency: merge #114 and prerequisites first. Focused change 7e62026…7f46d4d.
Validation at clean head
7f46d4d0a6164ab6101816ebdf09ee8dc7253640:79ea62f45fb2ea8f65d081a109431e4eb1bbdb36.d69167fc542c6ba680e551632706a6a9e30df82f: 94/104 engine suites, SDK 3/3, B30 and 128/256 cross-engine checks.The pinned Gen1 implementation delegates Gen1 static encounters to its native command, which does not namespace private beat flags. Shared Gen1 static cases use a real native beat flag; this host's consistent namespaced behavior is covered separately. Tests are ROM-free with native entry/timing seams; no ROM gameplay/pixel equivalence claim. Trainer encounters are the next separate slice.
Hosted Actions: API 3 contracts and ci are
action_required(fork workflow approval). Hosted tests have not run; the results above are local.