Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds API-3
warp(mapId, x, y, facing?)andremember_outdoor(mapId, x, y)on Gen1–3.The public warp adapter and scripts share a pure destination planner. Whole-program preflight follows the reference engine's linear map context and validates subsequent object/block/movement rows against destination definitions without loading a live map. Dispatch validates live data again. Arrival binds the continuation to the destination map and idle runner, clears talking-NPC context, and waits for the foreground before running later rows. One-shot callbacks and a bounded native-transition deadline prevent stale continuations.
The already admitted native transition remains engine-owned on unload/timeout, so it can finish arrival bookkeeping and release its own locks. Busy destination scripts are preserved and cause the portable run to fail.
Dependency: merge #113 and prerequisites first. Focused change 4632d3a…7e62026.
Validation at clean head
7e620268d09f78d8fc01664ba2329eb6e3936763:79ea62f45fb2ea8f65d081a109431e4eb1bbdb36, including warp followed by player/NPC movement.73b750d26fe1c74d1a419aa536b470035608910a: 93/103 engine suites, SDK 3/3, B30 and 120/240 cross-engine checks.ROM-free tests use native logic with synthetic destination materialization. No ROM gameplay/pixel equivalence claim. Future geometry validation requires the relevant destination tileset; branches/native entry scripts may change conditions after admission, which are checked again at runtime.
Hosted Actions: API 3 contracts and ci are
action_required(fork workflow approval). Hosted tests have not run; the results above are local.