Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portable scripts can now give canonical items and Pokémon through the native bag, party, Pokédex, box and receipt/nickname flows.
Adds
give_item(item, count?, gotText?, bagFullText?)andgive_pokemon(species, level, skipNickname?, gotText?), with whole-program validation before admission and live store validation at dispatch. Native gift dialogs use owned, one-shot continuations, including transitions from receipt to question to naming. Cancellation, unloading, replaced saves and replayed callbacks cannot resume a retired script. Existing non-portable command callers keep their native behavior.Dependency: merge #110 and its prerequisites first. This branch is stacked on #110 because those prerequisites are not yet upstream. Implementation-only diff: 235b8f9…7671788.
Validation at exact clean head
76717887264f26b93bc0343e27e23b93c607b88a:79ea62f45fb2ea8f65d081a109431e4eb1bbdb36, covering eight supported versions and actual native gift constructors.6e3d57541464e3b8f2354da33c34620109121fea: 90/100 engine suites, SDK 3/3 and B30 pass; same 27 baseline FAIL lines and 96/192 cross-engine checks.Tests use ROM-free fixtures with native commands and UI callbacks; no claim of ROM gameplay or pixel equivalence. Full-suite baseline failures and skipped ROM-content tier remain visible.
Hosted Actions: API 3 contracts and ci are
action_required(fork workflow approval). Hosted tests have not run; the results above are local.