Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #109 and its API prerequisites. Merge those first and rebase before merging. Isolated commit
235b8f975f9e4c74cf0775dc6f18e9cc7220439b(focused diff).Extend the bounded portable script language with give_money, take_money, check_money, take_coins, check_item, take_item, check_dex_owned, mark_seen and heal_party. Resolve canonical item/species IDs through the existing loader index. Validate the whole program's arguments, content and referenced live stores before any prefix runs, including unreachable rows; revalidate stores when executing after a wait.
Use native Bag.remove/order cleanup and Pokemon healing with the current Game's moves for PP. The optional moves argument preserves existing Pokemon.heal callers. Preserve the verified Gen1 API's wallet semantics: Gen2/3 cap addition at999999, Gen1 retains its native uncapped wallet, with host exact-integer overflow refusal. Removal saturates at available quantity/zero; no gift UI is introduced in this synchronous group.
Commands, bounds and reproduction.
Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36, clean feature head. Same public-only program on Red, Blue, Yellow, Gold, Silver, Crystal, FireRed and Emerald. Compare resulting money, coins, item quantity, seen state, HP/PP and conditional branches through the actual native save/bag/party backends.04ea058693a1801013343db1d09813eb2bc0e927): 89/99 engine, SDK3/3, B30 PASS; same exact baseline failures. All88 comparisons/176runs pass on that clean combined tree.Unchanged failing suites: gate_fingerprint, gate_meta_coverage, quit_thread_shutdown, rebind_capture_bug510, rebind_swap_clear_bug589, soft_reset_bug563, tool_mod_hooks, update_check_tests, update_tests, wide_battle_layout; full test entry remains nonzero.
Hosted CI
Published open/non-draft at the tested head. API 3 contracts and ci currently conclude
action_requiredpending maintainer fork-workflow approval. Hosted CI is not green; validation above ran locally.