Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #108 and its API prerequisites; merge those first and rebase before merging. Isolated commit
20fd4f6b0f4cd6c2546a5f447172aebc5f109f85(focused diff).Add set_flag/clear_flag/check_flag/wait_flag and setflag/clearflag aliases to the bounded portable script language. Validate and copy all references (including unreachable rows) and check all referenced flag stores before any prefix executes. Reuse #108's private/native addressing, ownership, native storage and Gen3 targeted visibility synchronization.
Flag conditions feed existing conditional jumps. wait_flag yields once, resumes on true or an optional whole 0–36000-frame timeout, and returns its boolean condition result. Omitted timeout waits until signaled/cancelled. Existing foreground ownership, overlay pausing, session invalidation, one-shot completion and runner cleanup remain in force. Resolve the already active world for native flag synchronization without asking the loader to bootstrap Game. Unknown native verbs remain rejected.
Commands and reproduction. Gen1's pinned API does not implement the host's scripts capability-query surface; the identical shared mod uses the common world/queueScript query, with host verb metadata tested separately.
Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. Same public-only flag program under both production loaders for Red, Blue, Yellow, Gold, Silver, Crystal, FireRed and Emerald. Uses the actual native condition/runner paths; synthetic world/store fixtures.047de5a2dc37508b98d603aa75fc3b2ee443baac): 88/98 engine, SDK3/3, B30 PASS; same exact baseline failures. All80 comparisons/160runs pass on the clean combined tree.Unchanged failing suites: gate_fingerprint, gate_meta_coverage, quit_thread_shutdown, rebind_capture_bug510, rebind_swap_clear_bug589, soft_reset_bug563, tool_mod_hooks, update_check_tests, update_tests, wide_battle_layout. Full test entry remains nonzero due to those baseline failures.
Hosted CI
Published open/non-draft at the tested head. API 3 contracts and ci currently conclude
action_requiredpending maintainer fork-workflow approval. Hosted CI is not green; validation above ran locally.