Skip to content

fix(shared): 37 个硬编码中文 title/subtitle 迁移到 i18n 资源 - #1750

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/shared-i18n-title-attrs
Aug 17, 2026
Merged

fix(shared): 37 个硬编码中文 title/subtitle 迁移到 i18n 资源#1750
DeliciousBuding merged 1 commit into
masterfrom
fix/shared-i18n-title-attrs

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

Summary

  • 33 个 title + 4 个 subtitle 属性从硬编码中文迁移到 sharedWorkbench namespace 的 t() 调用
  • 新增 settings.section.* (11 keys)、projects.section.* (12 keys)、contacts.section.* (5 keys with subtitles),zh + en
  • SettingsPanes/SettingsMain 使用双 namespace(CHATVIEW for aria, SHARED_WORKBENCH for section titles)
  • 覆盖 7 个文件:ContactMainParts、ContactMainViews、ProjectFeedPanel、ProjectPanelParts、ProjectTabViews、SettingsPanes、SettingsMain

验收

  • typecheck: PASS
  • i18n-callsites: 88 files / 773 CJK lines (baseline 104/930) — 进一步降低 42 行

Test plan

  • pnpm --filter @agenthub/shared typecheck — PASS
  • python scripts/verify/verify-i18n-callsites.py — PASS
  • CI full test suite

workbench 页面中 33 个 title 和 4 个 subtitle 属性仍使用硬编码中文,
英文 locale 用户会看到 mixed-language 界面。将全部迁移到 sharedWorkbench
namespace 的 t() 调用,新增 settings.section.* / projects.section.* /
contacts.section.* 键(zh + en),覆盖设置面板子区标题、项目面板分区
标题、联系人分组标题和副标题。

SettingsPanes/SettingsMain 使用双 namespace 模式(CHATVIEW for aria,
SHARED_WORKBENCH for section titles),避免 key-echo 返回 key 字符串。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ebb93609-0b5e-46eb-a18c-a8d1f1cf3a0e

📥 Commits

Reviewing files that changed from the base of the PR and between 9104c76 and fa86786.

📒 Files selected for processing (8)
  • app/shared/src/i18n/workbench.ts
  • app/shared/src/workbench/pages/contacts/ContactMainParts.tsx
  • app/shared/src/workbench/pages/contacts/ContactMainViews.tsx
  • app/shared/src/workbench/pages/projects/ProjectFeedPanel.tsx
  • app/shared/src/workbench/pages/projects/ProjectPanelParts.tsx
  • app/shared/src/workbench/pages/projects/ProjectTabViews.tsx
  • app/shared/src/workbench/pages/settings/SettingsMain.tsx
  • app/shared/src/workbench/pages/settings/SettingsPanes.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit ddf2746 into master Aug 17, 2026
32 of 34 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/shared-i18n-title-attrs branch August 17, 2026 20:25
DeliciousBuding added a commit that referenced this pull request Aug 17, 2026
SettingsMain title="设置加载失败" 迁移到 tw("settings.loadFailed") 后,
desktop/shared 测试 i18n 实例默认 'test' 语言(key-echo),tw() 返回
key 而非中文。将 SettingsPage.test.tsx 断言从 '设置加载失败' 改为
'settings.loadFailed' 匹配 key-echo 行为。

修复 PR #1750 引入的 frontend-desktop (1) 和 Frontend coverage baseline
(@agenthub/shared) CI 失败。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant