Skip to content

fix(shared): SettingsPage 测试 aria-label 断言对齐 key-echo 模式 - #1751

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/settings-test-key-echo
Aug 17, 2026
Merged

fix(shared): SettingsPage 测试 aria-label 断言对齐 key-echo 模式#1751
DeliciousBuding merged 1 commit into
masterfrom
fix/settings-test-key-echo

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • vitest run src/workbench/pages/SettingsPage.test.tsx — 3/3 PASS
  • CI full test suite

SettingsMain title="设置加载失败" 迁移到 tw("settings.loadFailed") 后,
desktop/shared 测试 i18n 实例默认 'test' 语言(key-echo),tw() 返回
key 而非中文。将 SettingsPage.test.tsx 断言从 '设置加载失败' 改为
'settings.loadFailed' 匹配 key-echo 行为。

修复 PR #1750 引入的 frontend-desktop (1) 和 Frontend coverage baseline
(@agenthub/shared) CI 失败。

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a02187d-a705-46b9-bb73-554013c5771b

📥 Commits

Reviewing files that changed from the base of the PR and between ddf2746 and 7309ece.

📒 Files selected for processing (1)
  • app/shared/src/workbench/pages/SettingsPage.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit b4853b1 into master Aug 17, 2026
34 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/settings-test-key-echo branch August 17, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant