-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feature/search teleport to file #4713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yasminhosam
wants to merge
4
commits into
TeamAmaze:release/4.0
Choose a base branch
from
yasminhosam:feature/search-teleport-to-file
base: release/4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9713c31
Add teleport to file feature from search results
yasminhosam 578543f
Merge branch 'release/4.0' into feature/search-teleport-to-file
yasminhosam f19ba54
Fix teleport path splitting to avoid android.util.Pair mocking issue …
yasminhosam f9aca24
Add missing KDoc to test functions
yasminhosam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
app/src/test/java/com/amaze/filemanager/ui/activities/MainActivityTeleportTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Copyright (C) 2014-2026 Arpit Khurana <arpitkh96@gmail.com>, Vishal Nehra <vishalmeham2@gmail.com>, | ||
| * Emmanuel Messulam<emmanuelbendavid@gmail.com>, Raymond Lai <airwave209gt at gmail.com> and Contributors. | ||
| * | ||
| * This file is part of Amaze File Manager. | ||
| * | ||
| * Amaze File Manager is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.amaze.filemanager.ui.activities | ||
|
|
||
| import org.junit.Assert.assertEquals | ||
| import org.junit.Assert.assertNull | ||
| import org.junit.Test | ||
|
|
||
| /** | ||
| * Tests for [MainActivity.splitParentAndFileName], used by the search | ||
| * "teleport to file" feature to navigate to a file's parent folder. | ||
| */ | ||
| class MainActivityTeleportTest { | ||
|
|
||
| /** Verifies a normal file path is split into its parent directory and file name. */ | ||
| @Test | ||
| fun `splits a normal file path into parent and file name`() { | ||
| val result = MainActivity.splitParentAndFileName("/storage/emulated/0/Documents/report.pdf") | ||
|
|
||
| assertEquals("/storage/emulated/0/Documents", result?.parentPath) | ||
| assertEquals("report.pdf", result?.fileName) | ||
| } | ||
|
|
||
| /** Verifies a path with only one directory level splits correctly. */ | ||
| @Test | ||
| fun `splits a path with a single directory level`() { | ||
| val result = MainActivity.splitParentAndFileName("/storage/file.txt") | ||
|
|
||
| assertEquals("/storage", result?.parentPath) | ||
| assertEquals("file.txt", result?.fileName) | ||
| } | ||
|
|
||
| /** Verifies null is returned when the path has no parent directory. */ | ||
| @Test | ||
| fun `returns null when path has no parent directory`() { | ||
| val result = MainActivity.splitParentAndFileName("file.txt") | ||
|
|
||
| assertNull(result) | ||
| } | ||
|
|
||
| /** Verifies file names with spaces and special characters split correctly. */ | ||
| @Test | ||
| fun `handles file names containing spaces and special characters`() { | ||
| val result = | ||
| MainActivity.splitParentAndFileName( | ||
| "/storage/emulated/0/WhatsApp/Media/Yasmin Hosam (1).pdf", | ||
| ) | ||
|
|
||
| assertEquals("/storage/emulated/0/WhatsApp/Media", result?.parentPath) | ||
| assertEquals("Yasmin Hosam (1).pdf", result?.fileName) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not using HybridFile here? Does this work with external searches: SMB, FTP, cloud, etc?