Feature/search teleport to file - #4713
Open
yasminhosam wants to merge 4 commits into
Open
Conversation
| * Simple holder for a file's parent path and name. Not an android.util.Pair to keep it usable in | ||
| * plain JUnit tests (android.* classes are stubbed out in non-Robolectric unit tests). | ||
| */ | ||
| static class ParentAndFileName { |
Member
There was a problem hiding this comment.
Any reason for not using HybridFile here? Does this work with external searches: SMB, FTP, cloud, etc?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "teleport to file" icon in search results. Tapping the new icon navigates to the file's parent folder and highlights/selects it there, so the user can act on it directly (rename, move, delete, etc.) without opening it first.
Directory results in search are unaffected — tapping a directory result still opens it directly, as before.
This reuses the existing
scrollToFileName+getScrollPosition()mechanism already present inMainActivity/MainFragment/MainFragmentViewModel, rather than duplicating scroll/highlight logic.Issue tracker
Fixes #4695
Automatic tests
Manual tests
Done
Device: Samsung Galaxy A23
OS: Android 14
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
This PR used generative code tools (GenAI, LLMs, etc.)
Model: Claude Sonnet 5
Version: 5
Provider: Anthropic