refactor: v2 - run view - windows top menu#2357
Draft
maxy-shpfy wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 3, 2026
Collaborator
Author
This was referenced Jun 3, 2026
🎩 PreviewA preview build has been created at: |
This was referenced Jun 3, 2026
f41fc1a to
6964ede
Compare
6964ede to
038202b
Compare
0261b2a to
3ffa687
Compare
038202b to
49fcf52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The
WindowsMenucomponent has been moved fromsrc/routes/v2/pages/Editor/components/EditorMenuBar/components/tosrc/routes/v2/shared/components/so it can be reused across different views. AtrackingPrefixprop has been introduced to allow each consumer to supply its own tracking namespace. TheEditorMenuBarpassesv2.pipeline_editor.windows_menuand theRunViewMenuBarpassesv2.run_view.windows_menu, with theWindowsMenunow also rendered in theRunViewMenuBar.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
v2.pipeline_editor.windows_menuprefix.v2.run_view.windows_menuprefix.Additional Comments