Skip to content

refactor: v2 - run view - windows top menu#2357

Draft
maxy-shpfy wants to merge 1 commit into
masterfrom
06-02-refactor_v2_-_run_view_-_windows_top_menu
Draft

refactor: v2 - run view - windows top menu#2357
maxy-shpfy wants to merge 1 commit into
masterfrom
06-02-refactor_v2_-_run_view_-_windows_top_menu

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Description

The WindowsMenu component has been moved from src/routes/v2/pages/Editor/components/EditorMenuBar/components/ to src/routes/v2/shared/components/ so it can be reused across different views. A trackingPrefix prop has been introduced to allow each consumer to supply its own tracking namespace. The EditorMenuBar passes v2.pipeline_editor.windows_menu and the RunViewMenuBar passes v2.run_view.windows_menu, with the WindowsMenu now also rendered in the RunViewMenuBar.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open the pipeline editor and verify the Windows menu renders correctly and tracking events fire with the v2.pipeline_editor.windows_menu prefix.
  2. Open a run view and verify the Windows menu now appears in the menu bar and tracking events fire with the v2.run_view.windows_menu prefix.
  3. Toggle window visibility and apply view presets in both views to confirm the correct tracking payloads are sent.

Additional Comments

maxy-shpfy commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-02-refactor_v2_-_run_view_-_windows_top_menu/49fcf52

@maxy-shpfy maxy-shpfy force-pushed the 06-02-refactor_v2_-_run_view_-_windows_top_menu branch from f41fc1a to 6964ede Compare June 11, 2026 06:01
@maxy-shpfy maxy-shpfy changed the base branch from 06-02-refactor_v2_-_ai_assistant_-_split_editor_and_view_agent_implementations to graphite-base/2357 June 11, 2026 06:17
@maxy-shpfy maxy-shpfy force-pushed the 06-02-refactor_v2_-_run_view_-_windows_top_menu branch from 6964ede to 038202b Compare June 11, 2026 06:21
@maxy-shpfy maxy-shpfy force-pushed the graphite-base/2357 branch from 0261b2a to 3ffa687 Compare June 11, 2026 06:21
@graphite-app graphite-app Bot changed the base branch from graphite-base/2357 to master June 11, 2026 06:22
@maxy-shpfy maxy-shpfy force-pushed the 06-02-refactor_v2_-_run_view_-_windows_top_menu branch from 038202b to 49fcf52 Compare June 11, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant