Skip to content

fix: v2 - window state for startVisible#2352

Merged
maxy-shpfy merged 1 commit into
masterfrom
06-02-fix_v2_-_window_state_for_startvisible
Jun 11, 2026
Merged

fix: v2 - window state for startVisible#2352
maxy-shpfy merged 1 commit into
masterfrom
06-02-fix_v2_-_window_state_for_startvisible

Conversation

@maxy-shpfy

@maxy-shpfy maxy-shpfy commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Attemp to fix https://github.com/Shopify/oasis-frontend/issues/654

When options.startVisible is set, the window should not be hidden even if there is no persisted layout. Previously, a window with startVisible enabled could still be forced into a hidden state when options.persisted was true and no persisted layout existed. This fix ensures that startVisible takes precedence over the default hidden state logic in that scenario.

Related Issue and Pull requests

Type of Change

  • Bug fix

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Configure a window with both persisted: true and startVisible: true.
  2. Ensure no persisted layout exists for the window.
  3. Verify the window renders as visible rather than being hidden.

Additional Comments

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 06-02-fix_v2_-_window_state_for_startvisible/414fb3c

maxy-shpfy commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jun 10, 11:59 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 11, 12:00 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 11, 12:03 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy force-pushed the 06-02-fix_v2_-_window_state_for_startvisible branch from ddb34e9 to 414fb3c Compare June 10, 2026 23:59
@maxy-shpfy maxy-shpfy merged commit 0c9b878 into master Jun 11, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 06-02-fix_v2_-_window_state_for_startvisible branch June 11, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants