Skip to content

chore: add one npm run check for the nine check scripts #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeiddata-dev wants to merge 1 commit into from
Closed

chore: add one npm run check for the nine check scripts #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,10 @@ jobs:
cache: npm
- run: npm ci
- run: npx tsc --noEmit
# One step, one line each: the failing script's name is the failure.
# The aggregate is `&&`-chained, so it still stops at the first failure
# and the failing script names itself in its own output.
- name: check scripts
run: |
npm run landing:check
npm run epoch:check
npm run bind:check
npm run dedupe:check
npm run reentry:check
npm run unclaimed:check
npm run notify:check
npm run spawn:check
npm run scope:check
run: npm run check

rust:
name: rust (${{ matrix.os }})
Expand Down
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ These are the merge gates. CI runs all of them except `golden`:
```bash
npx tsc --noEmit # TypeScript, strict
cd src-tauri && cargo clippy --all-targets -- -D warnings && cargo test
npm run landing:check && npm run epoch:check && npm run bind:check \
&& npm run dedupe:check && npm run reentry:check && npm run unclaimed:check \
&& npm run notify:check && npm run spawn:check && npm run scope:check
npm run check # all nine check scripts
```

`npm run golden` is the extraction golden set. It shells out to the `claude`
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"tauri": "tauri",
"reinstall": "sh scripts/reinstall.sh",
"golden": "tsx scripts/golden.ts",
"check": "npm run landing:check && npm run epoch:check && npm run bind:check && npm run dedupe:check && npm run reentry:check && npm run unclaimed:check && npm run notify:check && npm run spawn:check && npm run scope:check",
"landing:check": "tsx scripts/landing-check.ts",
"epoch:check": "tsx scripts/epoch-check.ts",
"bind:check": "tsx scripts/bind-check.ts",
Expand Down