chore: add one npm run check for the nine check scripts - #16
Closed
zeiddata-dev wants to merge 1 commit into
Closed
Conversation
The nine check scripts were written out longhand in three places — ci.yml, CONTRIBUTING.md, and everyone's shell history. Change the set and you had to remember all three. This adds a single aggregate script and points the other two at it. The `&&` chain keeps the property the nine-line CI step was protecting: it stops at the first failure, and the failing script still names itself. Verified by breaking bind-check on purpose — exit 1, `bind:check` named in both the npm header and the stack trace, and the six checks after it never ran. `golden` deliberately stays out. It shells out to the claude CLI and bills per run, so it remains a separate local-only gate. One thing worth a maintainer's eye: package.json has eleven `*:check` scripts, not nine. `clock:check` and `delta:check` (Phase 14) are in neither ci.yml nor CONTRIBUTING, so they're left out here to keep this to the issue as written — but `npm run check` now reads as exhaustive while quietly skipping two. Glad to fold them in if that omission wasn't deliberate. Closes SuperLogicAI#6 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WyeecwdT2gD3fxeWkJpTKa
Contributor
Author
|
Duplicate to #15. My apologies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6.
The nine check scripts were written out longhand in three places —
ci.yml,CONTRIBUTING.md, and everyone's shell history. Change the set and you had to remember all three. This adds a single aggregate script and points the other two at it.The constraint, verified rather than assumed
The issue flags that CI's nine-line step exists so the failing script's name is the failure.
&&preserves that. I checked instead of trusting it: appended a deliberatethrowtobind-check.ts(3rd in the chain) and rannpm run check.1> logic-loop@0.1.0 bind:checkin the npm header, and the file path in the stack trace — the failing script names itself twice overThen reverted the break;
git statusclean.goldenstays outUntouched, as the issue requires. It shells out to the
claudeCLI and bills per run, so it remains a separate local-only gate.One thing worth your eye
package.jsonhas eleven*:checkscripts, not nine.clock:checkanddelta:check(Phase 14) appear in neitherci.ymlnorCONTRIBUTING.md.I left them out to keep this PR to the issue as written — but it's worth naming that
npm run checknow reads as exhaustive while quietly skipping two, which is arguably a worse failure mode than the nine copied lines were. If that omission wasn't deliberate, say the word and I'll fold them in here or in a follow-up.Verification
npx tsc --noEmitclean,npm run checkpasses 9/9 on this branch.