Add a single npm run check that runs all nine check scripts - #15
Merged
SuperLogicAI merged 3 commits intoSep 6, 2026
Merged
Conversation
- package.json: add "check" chaining the nine *:check scripts with && - ci.yml: collapse the nine-line check step to npm run check - CONTRIBUTING.md: reference the one command in the merge-gates block golden stays a separate local-only gate. && short-circuits, so a failing script still names itself. Closes SuperLogicAI#6
Phase 14 added two new *:check scripts (clock, delta) that never made it into the aggregate — npm run check silently skipped them even though they're real merge gates per CLAUDE.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HV9mm7Y9ManEFp7H4suHmF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6.
One aggregate script instead of the nine-line block copied in three places.
package.json: addscheck, chaining the nine*:checkscripts with&&..github/workflows/ci.yml: thecheck scriptsstep is nownpm run check.CONTRIBUTING.md: the merge-gates block references the one command.goldenis deliberately left out; it shells out to the billedclaudeCLI and stays a separate local-only gate.Constraint check
The old CI step ran the nine on separate lines so the failing script named itself.
&&preserves that. Verified locally:npm run checkpasses all nine.landing:checkon purpose makesnpm run checkexit non-zero, and the output still nameslanding:check.&&short-circuits, so nothing after the failure runs.