configure toolkit for watch - #9
Open
SharonStrats wants to merge 1 commit into
Open
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Watch-mode plugin and output filtering mishandle valid Vite configuration shapes.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds watch-mode support while reducing unnecessary watch outputs.
Changes:
- Adds a
watchpackage script. - Disables declaration generation during watch mode.
- Limits watch builds to ES output.
| File | Description |
|---|---|
package.json |
Adds the watch command. |
src/vite/plugins/solid-pane.ts |
Omits DTS generation while watching. |
src/vite/config/build.ts |
Filters watch-mode build outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
fix/watch
branch
from
October 3, 2026 10:23
99cf723 to
eff2075
Compare
SharonStrats
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared toolkit watch behavior was updated so that watch mode now:
That reduces each rebuild to a single cleaner wave of file writes, which stops the watcher churn.
Note: @NoelDeMartin The rdflib dependency is a much lower version than our current one, not sure if I should change that too?
Also, more testing i ended up having to change mashilb webpack to point to solid-panes esm... i'm going to test some more before merge but would still like to get your feedback.