Skip to content

Run current-run E2E app cleanup in CI#7927

Merged
alfonso-noriega merged 1 commit into
mainfrom
06-24-e2e_always_cleanup
Jun 25, 2026
Merged

Run current-run E2E app cleanup in CI#7927
alfonso-noriega merged 1 commit into
mainfrom
06-24-e2e_always_cleanup

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

E2E tests can leave real Dev Dashboard apps behind when teardown is skipped or fails. The previous workflow did not run a post-test app cleanup step, so leftovers accumulated in the shared E2E organization.

Stacked on #7926: the cleanup pattern relies on the run-aware app names introduced by the parent PR.

WHAT is this pull request doing?

Adds an always() cleanup step after the E2E test command that computes the same compact run token as the E2E app-name helper and runs:

RUN_TOKEN=$(node -e "process.stdout.write(BigInt(process.env.GITHUB_RUN_ID).toString(36))")
pnpm --filter e2e exec tsx scripts/cleanup-apps.ts --pattern "r${RUN_TOKEN}a${GITHUB_RUN_ATTEMPT}"

The step targets only apps created by the current GitHub Actions run attempt and is marked continue-on-error: true so cleanup flakiness does not hide the original E2E result.

How to test your changes?

  • git diff --check
  • Inspect .github/workflows/tests-pr.yml and confirm the cleanup step is after Run E2E tests with if: ${{ always() }}.
  • In CI, verify the Cleanup current-run E2E apps step runs for E2E shards even if the test command fails.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is not user-facing, so no changeset is needed

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 25, 2026 14:47
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 25, 2026
Assisted-By: devx/3c9d2be5-81a1-4ad5-90ba-4155c6ff125d
@alfonso-noriega alfonso-noriega force-pushed the 06-24-e2e_app_names_include_run_id branch from d398cd8 to 5daa528 Compare June 25, 2026 14:53
@alfonso-noriega alfonso-noriega force-pushed the 06-24-e2e_always_cleanup branch from 5180815 to 0a69066 Compare June 25, 2026 14:53
Base automatically changed from 06-24-e2e_app_names_include_run_id to main June 25, 2026 15:39
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 5a6ca3f Jun 25, 2026
48 of 49 checks passed
@alfonso-noriega alfonso-noriega deleted the 06-24-e2e_always_cleanup branch June 25, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants