Skip to content

Use direct app URLs during E2E teardown#7928

Merged
alfonso-noriega merged 1 commit into
mainfrom
06-24-e2e_direct_app_url_teardown
Jun 25, 2026
Merged

Use direct app URLs during E2E teardown#7928
alfonso-noriega merged 1 commit into
mainfrom
06-24-e2e_direct_app_url_teardown

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

E2E teardown often searched the Dev Dashboard by app name, which gets slower and less reliable as the shared E2E organization accumulates apps. Some tests already have enough local TOML state to construct the direct Dev Dashboard app URL.

Stacked on #7927.

WHAT is this pull request doing?

  • Adds a devDashboardAppUrl helper that builds the app settings URL from the local TOML client_id and org ID.
  • Passes direct appUrl values into teardown for E2E tests where the app directory/config exists.
  • Keeps the existing dashboard search fallback for cases where a direct URL is unavailable.
  • Adds teardown logging to distinguish direct URL deletion from dashboard-search deletion.

How to test your changes?

  • pnpm --filter e2e lint
  • pnpm exec tsc -p packages/e2e/tsconfig.json --noEmit (prints “TypeScript: No errors found”, but exits 1 in this local wrapper)
  • git diff --check

For end-to-end confidence with credentials:

pnpm nx run-many --target=build --projects=cli,create-app --skip-nx-cache
cd packages/e2e
DEBUG=1 pnpm exec playwright test tests/app-dev-server.spec.ts

Then confirm teardown logs show using direct app URL for delete.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is not user-facing, so no changeset is needed

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 25, 2026 14:47
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 25, 2026
Assisted-By: devx/3c9d2be5-81a1-4ad5-90ba-4155c6ff125d
@alfonso-noriega alfonso-noriega force-pushed the 06-24-e2e_always_cleanup branch from 5180815 to 0a69066 Compare June 25, 2026 14:53
@alfonso-noriega alfonso-noriega force-pushed the 06-24-e2e_direct_app_url_teardown branch from 8190bb8 to 44d2cae Compare June 25, 2026 14:53
Base automatically changed from 06-24-e2e_always_cleanup to main June 25, 2026 15:50
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 3d1cb26 Jun 25, 2026
26 checks passed
@alfonso-noriega alfonso-noriega deleted the 06-24-e2e_direct_app_url_teardown branch June 25, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants