Repository navigation
fix(linux): retry transient uinput open errors - #66
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5 of 15 tasks
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry Linux
/dev/uinputopens only forENOENTandEACCES, with five total attempts and deterministic 10/20/40/40 ms backoff. Persistent failures exit nonzero with the device path, final error, andopencontroller-linux-uinput-doctor --checkguidance. No permissions or system configuration are changed.Source evidence
Issue #58 documents the transient startup race in Asahi-map #6 and the distinct persistent ownership case in Omarchy #8373. The change addresses the transient case and leaves persistent access configuration to existing guidance.
Acceptance covered
ENOENTandEACCESfrom the initial open.errno.sudo,chown,chmod, or permission mutation was added.Validation
bun test packages/native-linux-uinput/src/__tests__— 20 passed.bun run typecheck— passed.bun run build— passed.bun run pack:check— all seven packages passed; Linux helper header included.bun x biome checkon changed TypeScript, package manifest, and pack-check script — passed.ENOENTand doctor guidance.Closes #58