Skip to content

Extend incomplete replays properly when mines are present #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AiAe merged 1 commit into from
Jul 3, 2026
Merged

Extend incomplete replays properly when mines are present #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 49 additions & 33 deletions Quaver.API/Replays/Virtual/VirtualReplayPlayer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,39 +142,7 @@ public void PlayNextFrame()
{
if (CurrentFrame >= Replay.Frames.Count && !ExtendedFailingReplay && !DontExtendReplay)
{
// Handle when the replay isn't extended enough to have enough misses to cause a failure.
var totalJudgementCount = ScoreProcessor.GetTotalJudgementCount();
var totalScoredJudgements = ScoreProcessor.TotalJudgementCount;
var judgementDifference = totalJudgementCount - totalScoredJudgements;

if (judgementDifference != 0)
{
for (var i = totalScoredJudgements; i < totalJudgementCount; i++)
{
var obj = Map.GetHitObjectAtJudgementIndex(i);

var hitStat = obj.Type switch
{
HitObjectType.Normal => new HitStat(HitStatType.Miss, KeyPressType.None, obj, obj.StartTime,
Judgement.Miss, int.MinValue, ScoreProcessor.Accuracy, ScoreProcessor.Health),
HitObjectType.Mine => new HitStat(HitStatType.Hit, KeyPressType.None, obj, obj.StartTime,
Judgement.Marv, 0, ScoreProcessor.Accuracy, ScoreProcessor.Health),
_ => throw new ArgumentOutOfRangeException(nameof(obj.Type), obj.Type,
"Unhandled note type")
};

ScoreProcessor.CalculateScore(hitStat);

ScoreProcessor.Stats.Add(hitStat);

if (!ScoreProcessor.Failed)
continue;

ExtendedFailingReplay = true;
return;
}
}

ExtendWithRemainingHitObjects();
ExtendedFailingReplay = true;
return;
}
Expand All @@ -197,6 +165,54 @@ public void PlayNextFrame()
}
}

/// <summary>
/// Extends incomplete replays with misses from objects that are still active.
/// </summary>
private void ExtendWithRemainingHitObjects()
{
ActiveHitObjectsToRemove = new List<HitObjectInfo>();
ActiveHeldLongNotesToRemove = new List<HitObjectInfo>();
ActiveMinesToRemove = new List<HitObjectInfo>();

foreach (var hitObject in ActiveHeldLongNotes.OrderBy(x => x.EndTime).ToList())
{
var missedReleaseJudgement = ScoreProcessor.Windows.LNMissJudgement.Value;
var stat = new HitStat(HitStatType.Miss, KeyPressType.None, hitObject, hitObject.EndTime,
missedReleaseJudgement, int.MinValue, ScoreProcessor.Accuracy, ScoreProcessor.Health);

ScoreProcessor.CalculateScore(missedReleaseJudgement, true);
ScoreProcessor.Stats.Add(stat);
ActiveHeldLongNotesToRemove.Add(hitObject);

if (ScoreProcessor.Failed)
return;
}

foreach (var hitObject in ActiveHitObjects.OrderBy(x => x.StartTime).ToList())
{
AddMissedHitObject(hitObject);
ActiveHitObjectsToRemove.Add(hitObject);

if (ScoreProcessor.Failed)
return;
}
}
Comment on lines +177 to +199

private void AddMissedHitObject(HitObjectInfo hitObject)
{
var stat = new HitStat(HitStatType.Miss, KeyPressType.None, hitObject, hitObject.StartTime,
Judgement.Miss, int.MinValue, ScoreProcessor.Accuracy, ScoreProcessor.Health);

ScoreProcessor.CalculateScore(stat);
ScoreProcessor.Stats.Add(stat);

if (!hitObject.IsLongNote)
return;

ScoreProcessor.CalculateScore(Judgement.Miss, true, false);
ScoreProcessor.Stats.Add(stat);
}

/// <summary>
/// Plays the entire replay.
/// </summary>
Expand Down
Loading