Extend incomplete replays properly when mines are present#219
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates VirtualReplayPlayer’s “extend incomplete replay” logic to avoid relying on Qua.GetHitObjectAtJudgementIndex, which became unreliable after mines were introduced, and instead bases extension on the remaining active object collections.
Changes:
- Replaces the previous judgement-index-based extension loop with
ExtendWithRemainingHitObjects(). - Adds
ExtendWithRemainingHitObjects()/AddMissedHitObject()helpers to synthesize miss judgements for still-active notes (and LN releases).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+177
to
+199
| foreach (var hitObject in ActiveHeldLongNotes.OrderBy(x => x.EndTime).ToList()) | ||
| { | ||
| var missedReleaseJudgement = ScoreProcessor.Windows.LNMissJudgement.Value; | ||
| var stat = new HitStat(HitStatType.Miss, KeyPressType.None, hitObject, hitObject.EndTime, | ||
| missedReleaseJudgement, int.MinValue, ScoreProcessor.Accuracy, ScoreProcessor.Health); | ||
|
|
||
| ScoreProcessor.CalculateScore(missedReleaseJudgement, true); | ||
| ScoreProcessor.Stats.Add(stat); | ||
| ActiveHeldLongNotesToRemove.Add(hitObject); | ||
|
|
||
| if (ScoreProcessor.Failed) | ||
| return; | ||
| } | ||
|
|
||
| foreach (var hitObject in ActiveHitObjects.OrderBy(x => x.StartTime).ToList()) | ||
| { | ||
| AddMissedHitObject(hitObject); | ||
| ActiveHitObjectsToRemove.Add(hitObject); | ||
|
|
||
| if (ScoreProcessor.Failed) | ||
| return; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was due to
Qua.GetHitObjectAtJudgementIndexno longer being accurate way of doing the thing it's named because of the introduction of mines. Now we don't use it and just useActiveMine/ActiveHitObjects/ActiveHeldLongNotesinstead.I found the bug and Codex fixed it. =)