Skip to content

CODE_STYLE.md: do caller sanity checks before acting #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 2 commits into from
Nov 3, 2026
Merged

CODE_STYLE.md: do caller sanity checks before acting #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e48c69
CODE_STYLE.md: validate arguments and preconditions before acting
jnasbyupgrade Nov 3, 2026
0cf1e4c
CODE_STYLE.md: narrow validate-before-acting rule to caller sanity ch…
jnasbyupgrade Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CODE_STYLE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ protection it exists to provide, not simplifying dead weight (see
[Postgres-Extensions/test_factory#18](https://github.com/Postgres-Extensions/test_factory/pull/18),
where this was done and then reverted).

## Validate before acting

Do caller sanity checks (argument validation) before taking any
meaningful action, unless there is a good reason to wait.

## Closing non-indentable blocks

When closing a code block that cannot be indented to show its nesting
Expand Down