Skip to content

CODE_STYLE.md: do caller sanity checks before acting - #43

Merged
jnasbyupgrade merged 2 commits into
Postgres-Extensions:mainfrom
jnasbyupgrade:validate-before-acting
Nov 3, 2026
Merged

jnasbyupgrade merged 2 commits into
Postgres-Extensions:mainfrom
jnasbyupgrade:validate-before-acting

Conversation

@jnasbyupgrade

@jnasbyupgrade jnasbyupgrade commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Do caller sanity checks (argument validation) before taking any meaningful action, unless there is a good reason to wait.

Caller sanity checks belong before any meaningful action, unless
there is a good reason to wait.

Prompted by review feedback on
Postgres-Extensions/object_reference#45
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 196114eb-0933-4b79-8e97-de5c2a881dfc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

…ecks

Match the rule's wording to its source: caller sanity checks (argument
validation) before any meaningful action, unless there is a good reason
to wait.
@jnasbyupgrade jnasbyupgrade changed the title CODE_STYLE.md: validate arguments and preconditions before acting CODE_STYLE.md: do caller sanity checks before acting Nov 3, 2026
@jnasbyupgrade
jnasbyupgrade merged commit e4fbd08 into Postgres-Extensions:main Nov 3, 2026
1 check passed
@jnasbyupgrade
jnasbyupgrade deleted the validate-before-acting branch November 3, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant