Skip to content

build(deps): clear the pnpm audit findings (vitest 5, dev tooling updates, root vitest removed) - #89

Merged
PAMulligan merged 2 commits into
chore/claude-code-conformancefrom
fix/79-dev-deps-audit
Oct 23, 2026
Merged

PAMulligan merged 2 commits into
chore/claude-code-conformancefrom
fix/79-dev-deps-audit

Conversation

@PAMulligan

Copy link
Copy Markdown
Contributor

Closes #79. Stacked on #83 (base chore/claude-code-conformance), because the first half of the fix, dropping standard-version from both manifests, landed there. GitHub retargets this PR to main when #83 merges.

What changed

  • Root: the unused vitest devDependency is gone (it was committed only to stop a local fast-forward conflict; nothing at the root uses it). The root lockfile is now empty. pnpm audit: no known vulnerabilities.
  • App, dev tooling only: vitest and @vitest/coverage-v8 3.2.4 → 5.0.5 (vite stays on 6.4.x, which vitest 5 supports), the other devDependencies updated within their ranges (vite 6.4.5, crxjs 2.7.1, eslint 9.39.5, postcss 8.5.31, sharp 0.35.5, typescript 5.9.3, @playwright/test 1.64.1), the vulnerable transitive packages re-resolved, and @types/node made explicit because vitest 4 stopped pulling it in. Every runtime dependency (react, react-dom, zustand, jose, @anthropic-ai/sdk, tailwind-merge, clsx, lucide-react, canvas-confetti) resolves to the same version as on main, so the shipped bundle is unchanged.
  • Two test adjustments for vitest 4+ semantics: the Anthropic SDK constructor mock is a function (mocks really construct under new now), and the three store-action mocks in ai.test.ts carry the store's own function types.

Audit

Lockfile Before (on main) After
root 3 critical, 13 high, 13 moderate, 2 low none
app 3 critical, 42 high (eslint, postcss, crxjs, sharp, ws, vite chains) 0 critical, 0 high, 1 moderate

The one moderate is postcss-selector-parser 6.x pinned by tailwindcss 3.4 (postcss-nested), patched only in 7.1.6; it needs Tailwind 4 or a major-version override and is left as is.

Verification

pnpm -C app lint            clean
pnpm -C app tsc --noEmit    clean
pnpm -C app test            545 passed (32 files)
pnpm -C app build           ok
pnpm -C app test:e2e        26 passed (headed Chromium, local)
pnpm audit --audit-level high   exit 0 in app/ and at the root

Note on the issue's third acceptance item: Dependabot alerts are enabled on the repo but automated security fixes are off, so Dependabot opens no security PRs either way.

🤖 Generated with Claude Code

PAMulligan and others added 2 commits October 23, 2026 13:20
The root vitest was committed in e039533 only to stop a recurring local
fast-forward conflict; no test or config at the root uses it (the hook
tests run on node:test). Removing it clears the three high findings
pnpm audit reported through vitest 4.1.10 > vite 8.1.x at the root (#79).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…audit

Dev tooling only; every runtime dependency resolves to the same version
as on main. vitest and @vitest/coverage-v8 move 3.2.4 to 5.0.5 (clears
the critical tinypool and vitest advisories; vite stays on 6.4.x, which
vitest 5 supports), the other devDependencies move within their ranges
(vite 6.4.5, crxjs 2.7.1, eslint 9.39.5, postcss 8.5.31, sharp 0.35.5,
typescript 5.9.3) and the vulnerable transitive packages are
re-resolved. @types/node is now explicit because vitest 4 stopped
pulling it in.

Two tests needed vitest 4 era changes: the Anthropic SDK constructor mock
uses a function (vi.fn mocks really construct under new now), and the
three store-action mocks in ai.test.ts carry the store's own function
types (a bare vi.fn() no longer assigns to a typed field).

pnpm audit: 0 critical, 0 high; one moderate remains
(postcss-selector-parser 6.x pinned by tailwindcss 3.4, patched only in
7.1.6). Verified: lint, tsc, 545 unit tests, build, 26 e2e (#79).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@PAMulligan
PAMulligan merged commit b55f6c8 into chore/claude-code-conformance Oct 23, 2026
@PAMulligan
PAMulligan deleted the fix/79-dev-deps-audit branch October 23, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant