Repository navigation
build(deps): clear the pnpm audit findings (vitest 5, dev tooling updates, root vitest removed) - #90
Merged
Merged
Conversation
The root vitest was committed in e039533 only to stop a recurring local fast-forward conflict; no test or config at the root uses it (the hook tests run on node:test). Removing it clears the three high findings pnpm audit reported through vitest 4.1.10 > vite 8.1.x at the root (#79). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…audit Dev tooling only; every runtime dependency resolves to the same version as on main. vitest and @vitest/coverage-v8 move 3.2.4 to 5.0.5 (clears the critical tinypool and vitest advisories; vite stays on 6.4.x, which vitest 5 supports), the other devDependencies move within their ranges (vite 6.4.5, crxjs 2.7.1, eslint 9.39.5, postcss 8.5.31, sharp 0.35.5, typescript 5.9.3) and the vulnerable transitive packages are re-resolved. @types/node is now explicit because vitest 4 stopped pulling it in. Two tests needed vitest 4 era changes: the Anthropic SDK constructor mock uses a function (vi.fn mocks really construct under new now), and the three store-action mocks in ai.test.ts carry the store's own function types (a bare vi.fn() no longer assigns to a typed field). pnpm audit: 0 critical, 0 high; one moderate remains (postcss-selector-parser 6.x pinned by tailwindcss 3.4, patched only in 7.1.6). Verified: lint, tsc, 545 unit tests, build, 26 e2e (#79). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79. Replaces #89, which was merged into the #83 branch after #83 had already landed on
main, so its commits never reachedmain; this is the same two commits replayed onto currentmain.What changed
vitestdevDependency is gone (it was committed only to stop a local fast-forward conflict; nothing at the root uses it). The root lockfile is now empty.pnpm audit: no known vulnerabilities.vitestand@vitest/coverage-v83.2.4 → 5.0.5 (vite stays on 6.4.x, which vitest 5 supports), the other devDependencies updated within their ranges (vite 6.4.5, crxjs 2.7.1, eslint 9.39.5, postcss 8.5.31, sharp 0.35.5, typescript 5.9.3, @playwright/test 1.64.1), the vulnerable transitive packages re-resolved, and@types/nodemade explicit because vitest 4 stopped pulling it in. Every runtime dependency (react, react-dom, zustand, jose, @anthropic-ai/sdk, tailwind-merge, clsx, lucide-react, canvas-confetti) resolves to the same version as onmain, so the shipped bundle is unchanged.function(mocks really construct undernewnow), and the three store-action mocks inai.test.tscarry the store's own function types.Audit
main)The one moderate is
postcss-selector-parser6.x pinned bytailwindcss3.4 (postcss-nested), patched only in 7.1.6; it needs Tailwind 4 or a major-version override and is left as is.Verification
Note on the issue's third acceptance item: Dependabot alerts are enabled on the repo but automated security fixes are off, so Dependabot opens no security PRs either way.
🤖 Generated with Claude Code