Skip to content

feat(symfony): add service container intelligence - #398

Open
sidux wants to merge 19 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-service-container-intelligence
Open

feat(symfony): add service container intelligence#398
sidux wants to merge 19 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-service-container-intelligence

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • index Symfony PHP configuration alongside YAML/XML resources
  • navigate, rename, complete, and diagnose service IDs and parameters across configuration and PHP usage sites
  • link PHP config class constants and callable methods back to declarations and CodeLens destinations
  • update watched PHP config resources incrementally
  • make PHP resource scanning safe at Unicode search boundaries and for whitespace-only literals

Why

Symfony service and parameter identifiers are semantic links even though PHP represents them as strings. Without a shared resource index, each editor feature would need its own hardcoded scan and would disagree about declarations, references, and missing symbols. Feeding PHP config into the same indexed model keeps navigation consistent and avoids repeated workspace scans.

Dependencies

Validation

  • focused navigation, completion, diagnostic, and scanner tests
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test — 14,135 passed, 12 ignored

@codecov-commenter

codecov-commenter commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.45590% with 640 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/framework.rs 87.30% 266 Missing ⚠️
src/code_lens.rs 86.60% 134 Missing ⚠️
src/rename/prepare.rs 61.24% 50 Missing ⚠️
src/completion/symfony.rs 83.88% 39 Missing ⚠️
src/indexing/watch.rs 40.32% 37 Missing ⚠️
src/definition/resolve.rs 40.00% 33 Missing ⚠️
src/references/members.rs 94.62% 23 Missing ⚠️
src/references/dispatch.rs 68.11% 22 Missing ⚠️
src/reference_counts.rs 95.64% 18 Missing ⚠️
src/resource_navigation.rs 96.81% 8 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

@AJenbo AJenbo added this to the Sprint 8 milestone Aug 27, 2026
@sidux sidux mentioned this pull request Aug 27, 2026
6 tasks
sidux added 7 commits August 30, 2026 17:12
Use the coarse reference index for conclusive zero counts and cache bounded exact member locations for non-zero lenses. Refresh-capable clients avoid eager resolve storms while older clients retain lazy resolution.
Stop reference counts and CodeLens resolves from repeating the full workspace walk for every declaration. Internal annotation requests share the initial index, including callers queued behind it, while an explicit Find References command keeps its single refresh for files created without watcher notifications.
@sidux
sidux force-pushed the feat/symfony-service-container-intelligence branch from 79d238e to 02d3a52 Compare August 30, 2026 15:33
sidux added 12 commits August 30, 2026 17:40
Resolve fully-qualified classes and Class::member references from arbitrary YAML and XML positions without schema-specific rules.
Feed schema-free class and member occurrences into Find References and CodeLens, including transparent-proxy metadata aliases.
Index semantic framework relationships alongside generic YAML and XML class references.
Pass every indexed target to editor-native navigation and ignore empty PHP resource strings.
Generic YAML and XML navigation now returns early only when it resolves a PHP symbol. Otherwise the semantic Symfony resolver still handles aliases, form fields, validation mappings, and configuration keys.
Build entity-to-repository pairs alongside the framework resource index and update them per URI. CodeLens and reference lookups now read the derived index instead of reopening and rescanning every YAML/XML resource for each declaration.
@sidux
sidux force-pushed the feat/symfony-service-container-intelligence branch from 02d3a52 to fd29607 Compare August 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants