Skip to content

feat(symfony): add route intelligence - #399

Open
sidux wants to merge 20 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-route-intelligence
Open

feat(symfony): add route intelligence#399
sidux wants to merge 20 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-route-intelligence

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • index Symfony route declarations from YAML, XML, PHP config, and PHP attributes
  • navigate, find, rename, complete, and diagnose route names across PHP, config, and Twig usages
  • model route parameters with route-local scope
  • add declaration CodeLens links for route configuration and attributes

Why

Route names and placeholders form a project-wide symbol space, but they are spread across several configuration formats and string-based APIs. Treating them as indexed Symfony symbols gives every LSP feature one source of truth and prevents unrelated routes with the same placeholder name from being mixed together.

Dependencies

Validation

  • focused route navigation, completion, rename, diagnostic, and CodeLens tests
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test — 14,137 passed, 12 ignored

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.28771% with 368 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/code_lens.rs 86.97% 134 Missing ⚠️
src/completion/symfony.rs 82.56% 57 Missing ⚠️
src/rename/prepare.rs 61.19% 52 Missing ⚠️
src/indexing/watch.rs 40.32% 37 Missing ⚠️
src/references/members.rs 94.62% 23 Missing ⚠️
src/references/dispatch.rs 70.27% 22 Missing ⚠️
src/reference_counts.rs 95.64% 18 Missing ⚠️
src/definition/resolve.rs 86.20% 8 Missing ⚠️
src/resource_navigation.rs 96.81% 8 Missing ⚠️
src/reference_index.rs 94.73% 6 Missing ⚠️
... and 3 more

📢 Thoughts on this report? Let us know!

@AJenbo AJenbo added this to the Sprint 8 milestone Aug 27, 2026
@sidux sidux mentioned this pull request Aug 27, 2026
6 tasks
sidux added 7 commits August 30, 2026 17:12
Use the coarse reference index for conclusive zero counts and cache bounded exact member locations for non-zero lenses. Refresh-capable clients avoid eager resolve storms while older clients retain lazy resolution.
Stop reference counts and CodeLens resolves from repeating the full workspace walk for every declaration. Internal annotation requests share the initial index, including callers queued behind it, while an explicit Find References command keeps its single refresh for files created without watcher notifications.
@sidux
sidux force-pushed the feat/symfony-route-intelligence branch from 896956c to ab8aabd Compare August 30, 2026 15:33
sidux added 13 commits August 30, 2026 17:40
Resolve fully-qualified classes and Class::member references from arbitrary YAML and XML positions without schema-specific rules.
Feed schema-free class and member occurrences into Find References and CodeLens, including transparent-proxy metadata aliases.
Index semantic framework relationships alongside generic YAML and XML class references.
Pass every indexed target to editor-native navigation and ignore empty PHP resource strings.
Generic YAML and XML navigation now returns early only when it resolves a PHP symbol. Otherwise the semantic Symfony resolver still handles aliases, form fields, validation mappings, and configuration keys.
Build entity-to-repository pairs alongside the framework resource index and update them per URI. CodeLens and reference lookups now read the derived index instead of reopening and rescanning every YAML/XML resource for each declaration.
@sidux
sidux force-pushed the feat/symfony-route-intelligence branch from ab8aabd to 086d08a Compare August 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants