Skip to content

fix(finetune): respect later-turn image placeholders - #138

Merged
tc-mb merged 1 commit into
OpenSQZ:mainfrom
primorLee:fix/later-turn-single-image-placeholder
Aug 24, 2026
Merged

fix(finetune): respect later-turn image placeholders#138
tc-mb merged 1 commit into
OpenSQZ:mainfrom
primorLee:fix/later-turn-single-image-placeholder

Conversation

@primorLee

Copy link
Copy Markdown
Contributor

Summary

  • scan all conversation turns when replacing the single-image placeholder
  • preserve the existing first-turn fallback when no placeholder is present
  • add regression coverage for later-turn placement and the fallback path

Context

This carries the focused finetuning fix from OpenBMB/MiniCPM-V#1134 into the actively maintained Cookbook, as requested by the MiniCPM-V maintainer in that PR.

Test

  • python -X utf8 -m unittest finetune/official/test_dataset.py (2 passed)
  • ruff check finetune/official/test_dataset.py
  • ruff format --check finetune/official/test_dataset.py

@CLAassistant

CLAassistant commented Aug 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tc-mb
tc-mb merged commit 24fec10 into OpenSQZ:main Aug 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants