fix: respect later-turn single-image placeholders - #1134
Closed
primorLee wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks @primorLee ! Great catch on the later-turn single-image placeholder handling. Finetune is no longer maintained in MiniCPM-V — could re-submit to MiniCPM-V-Cookbook , if the corresponding code still exists there. Happy to review it there. |
Author
|
Thanks for the guidance. I migrated the focused fix and regression coverage to OpenSQZ/MiniCPM-V-CookBook#138, where the corresponding finetune/official/dataset.py code is maintained. Closing this PR to keep the old repository review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<image>, rather than assuming it is always in turn zero.Testing
python3 -m unittest discover -s finetune -p 'test_dataset.py' -vpython3 -m py_compile finetune/dataset.py finetune/test_dataset.pyThe focused regression test stubs optional training dependencies and verifies both later-turn placement and the no-placeholder fallback.