Repository navigation
Consume page-owned message evidence in wire fragments - #1360
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P993 paired consumer for OpenHCSDev/agent-comms#3659: 1 production file, +2/-2. One per-message evidence lookup becomes one paired iteration for the whole page. No new cache, index, wrapper, fragment type, or compatibility path.
Landing sequence: Core #3659 first. After its merge, this same PR will run
uv lock --upgrade-package agent-comms, commit the refreshed lock, and land through the merge queue. This initial source checkpoint deliberately does not pretend the old lock contains the new API.Before / after
WireSource.readpreviously built each fragment frompage.messagesand independently askedpage.evidence_for(message)for its original evidence page. Core rescanned the source pages for each such question.It now iterates
for message, evidence in page.message_evidence()and passes that evidence directly to the existingWireFragment.of. Message order, original evidence-page identity, viewer, style, fragment dispatch, measured page preparation, and page-edge construction are unchanged.Core's MessagePage owns the association. Toad consumes it instead of reissuing the lookup per message. No source ownership moved into a UI field.
Source coverage and integration
Existing NRA source parser/index inventoried Core and Toad production roots: 917 modules, 13 related, no parser failures. Declarations, inheritance, imports, writes, decisions, and named consumers are retained in
/home/ts/.cache/agent-scratch/producer-digest/p993-source-before.json; dynamic bindings and runtime mutation are outside that inventory's proof.The older Toad queue carrier #1319 modifies this same constructor line by passing an additional
page=pageargument. That independent argument must be retained when the carrier reaches main; the batched evidence iteration must also remain. This PR does not take over the carrier's fragment/notification ownership.Verification still owed
No author pytest, full suite, local ratchet, profile, install, or provider run. Combined execution belongs to the integration owner. Required path: Core
tests/test_historical_views.pyplus Toadtests/textual/test_wire_source.py; then actual Toad attached-archive channel opening and backward scrolling, confirming message order, original read evidence, and has-newer edges. Published source is not installed acceptance.Assumed: