Repository navigation
P958: retain the context annotation reader across inspections - #1363
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 30, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P958 production caller companion — source checkpoint, NOT qualified
Head bcc8ce7, push and ls-remote match. Current main is included.
git diff --stat origin/main...HEAD: 3 files, +6/-21. Latest commit: 3 files, +4/-19.Matched Core: OpenHCSDev/agent-comms#3613, head 1598bda4a03b34f8922ffdbfb8d3cdcc18dcd205. The API/caller pair is not independently landable. Earlier nominal fixture companion #1346 is merged; this PR does not reopen it or duplicate the unrelated producer-digest companion #1360.
Before / after
Verification boundary
All three changed Toad sources were syntax-compiled, alongside 34 changed Core sources: 37 total, exit 0. No author tests, checkers, product import probes, provider/UI calls, services or install. Root owns matched execution and actual saved-session journey.
The Core checkpoint still has a disclosed startup-context identity defect at owner_launch.py:162 (AcpSessionId(self.thread)); that is retained as an open P958 correction, not called a complete migration. Both PRs still need exact-head review and qualification.
Historical Core qualification remains 14 passed /2 failed at 3b8f1540a, not a clean result. The original installed P958 acceptance remains worker <15% CPU with >=2 streaming agents and <50 registry-lock opens/10s, measured by root; AFTER is unmeasured.
Assumed: syntax and name closure are not runtime/MRO/transport proof. No statement that this source is installed or that it fixes the separately owned shared-stdio settlement timeouts.
Receipts: /home/ts/.cache/agent-scratch/slot-activity/p958-toad-contract-publish.log and p958-contract-syntax.log.