Repository navigation
Conversation
This was referenced Oct 29, 2026
Closed
3 of 5 tasks
…kage-declarations--P918--toad-current
This was referenced Oct 31, 2026
Author
|
Closing as superseded: toad main imports from the Core nominal owners since 100b7dc ("Import nominal declarations from agent_comms.nominal"), and its Core pair agent-comms #3614 is closed for the same reason (865135f71). Stale-backlog pass at Tristan's request. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary in numbers
P918 paired consumer: 6 branch commits, 95 files,+111/-111 against included ToAD main
0312fc46c684fa9d04db330fe62ac9967dc6d766.03da3d00b2a0b17b5c08534bede88f5f41ed9701.2f510df6cc918008e30d0122962bb3bc623be8f3, including Core main068c96371.4c3c4f3a03cd86b54453d83862d66df106c90fba. Earlier preparation heads remain ancestors; original Follow Core nominal declarations into their defining package #1313 is closed as superseded with its branch/commits retained.Preparation only; no tests, builds, providers, installation or application acceptance by this author. Core3614 and ToAD1330 must be integrated in ONE paired batch. The exact Core747 debt-src job lists55 client files:52 already changed here;3 untouched indirect consumers have no moved import and use migrated parent families. This is not a type-check pass; all55 rows and original-commit dispositions are recorded in paired-747-client-match.md and on the paired Core review. UncarriedRecordFormat+3 is a separate actual growth line, not resolved by import pairing.
Before / after ownership
Before: actual consumers imported the four defining Core modules from the flat package root.
After: 110 import observations /94 files/5 lexical nested imports refer to
agent_comms.nominal.{declared_family,field_codec,json_schema,sealed}. Function-local imports remain local. The active keymap-plan owner path follows the declaration. No forwarding module, reexport, registry clone or compatibility codec.Core moves the complete declarations and retains the actual metaclass/registration/sealing owners. ToAD consumes them; it does not define a second family. Existing queue, notification, editor and routing implementations are not copied from pending branches.
One description derivation, no member literal
The latest review correction deletes AgentKindText's
schema_descriptionliteral. It inherits Core TextRepresentation.schema, which derivesf"{cls.__qualname__} text"once. Fourteen production Core literals and the test HexInteger literal are removed in the paired change as well.This intentionally changes the earlier module-qualified wording contract to class-qualified wording; no claim that the prior AgentKindText description is preserved. No wire selector, encode/decode behavior or class name is changed. Root owns actual schema/installed qualification.
Source evidence and limits
Reuse the retained complete census/map, not a new corpus scan. Initial ToAD preparation parsed 633 Python files, zero selected parse omissions and zero executable old-address imports on that source cut. Later landed prompt behavior and test changes remain preserved; no migration edit was needed for those increments.
Evidence lives under
/home/ts/.cache/agent-scratch/package-declarations/:current-{relocation-plan,source-closure}.json,restart-toad-ast-{before,after}.json,schema-description-{before,after}.json,follow-main-{before,after}.json,paired-747-client-match.{json,md},four-commit-path-disposition.jsonand currentfollow-main-toad-diff-stat.txt. Latest description evidence is a targeted eight-module Core/ToAD family inspection using NRA ModuleSyntaxIndex, not runtime execution. No generated converter/scanner is retained.The import/module relocation is authored using NRA syntax/module identity evidence, not native-codemod execution proof. Arbitrary computed imports/reflection and uninspected distributions remain unresolved. Installed identity, discovery, seal enforcement and saved-session behavior are not proved by parsing source.
Remaining integration
P918 stays last behind accepted overlapping features: P957/P927/Core3566/ToAD1319, current P954/P958 corrections and other accepted consumers. Final imports must close on their actual combined tree. No pending feature source is manually ported here.
Core #3576 /ToAD #1313 were closed only after targeted delta comparison showed their migration work carried; all original branches/commits remain intact. No application obligation closed with those PRs.
Root owes current-head source review, one combined matched selection, schema/observation-key assessment and installed tool/member discovery plus saved-session concurrent-native-reply/fresh-DM/open-tab-return journey.
Assumed: the latest class-qualified wording instruction supersedes the earlier module-qualified contract; this source checkpoint is not final integration or runtime acceptance.