Skip to content

P918: relocate current ToAD consumers to Core nominal owners - #1330

Closed
trissim wants to merge 6 commits into
mainfrom
work/package-declarations--P918--toad-current
Closed

trissim wants to merge 6 commits into
mainfrom
work/package-declarations--P918--toad-current

Conversation

@trissim

@trissim trissim commented Oct 29, 2026 •

Copy link
Copy Markdown

Summary in numbers

P918 paired consumer: 6 branch commits, 95 files,+111/-111 against included ToAD main 0312fc46c684fa9d04db330fe62ac9967dc6d766.

Preparation only; no tests, builds, providers, installation or application acceptance by this author. Core3614 and ToAD1330 must be integrated in ONE paired batch. The exact Core747 debt-src job lists55 client files:52 already changed here;3 untouched indirect consumers have no moved import and use migrated parent families. This is not a type-check pass; all55 rows and original-commit dispositions are recorded in paired-747-client-match.md and on the paired Core review. UncarriedRecordFormat+3 is a separate actual growth line, not resolved by import pairing.

Before / after ownership

Before: actual consumers imported the four defining Core modules from the flat package root.

After: 110 import observations /94 files/5 lexical nested imports refer to agent_comms.nominal.{declared_family,field_codec,json_schema,sealed}. Function-local imports remain local. The active keymap-plan owner path follows the declaration. No forwarding module, reexport, registry clone or compatibility codec.

Core moves the complete declarations and retains the actual metaclass/registration/sealing owners. ToAD consumes them; it does not define a second family. Existing queue, notification, editor and routing implementations are not copied from pending branches.

One description derivation, no member literal

The latest review correction deletes AgentKindText's schema_description literal. It inherits Core TextRepresentation.schema, which derives f"{cls.__qualname__} text" once. Fourteen production Core literals and the test HexInteger literal are removed in the paired change as well.

This intentionally changes the earlier module-qualified wording contract to class-qualified wording; no claim that the prior AgentKindText description is preserved. No wire selector, encode/decode behavior or class name is changed. Root owns actual schema/installed qualification.

Source evidence and limits

Reuse the retained complete census/map, not a new corpus scan. Initial ToAD preparation parsed 633 Python files, zero selected parse omissions and zero executable old-address imports on that source cut. Later landed prompt behavior and test changes remain preserved; no migration edit was needed for those increments.

Evidence lives under /home/ts/.cache/agent-scratch/package-declarations/: current-{relocation-plan,source-closure}.json, restart-toad-ast-{before,after}.json, schema-description-{before,after}.json, follow-main-{before,after}.json, paired-747-client-match.{json,md}, four-commit-path-disposition.json and current follow-main-toad-diff-stat.txt. Latest description evidence is a targeted eight-module Core/ToAD family inspection using NRA ModuleSyntaxIndex, not runtime execution. No generated converter/scanner is retained.

The import/module relocation is authored using NRA syntax/module identity evidence, not native-codemod execution proof. Arbitrary computed imports/reflection and uninspected distributions remain unresolved. Installed identity, discovery, seal enforcement and saved-session behavior are not proved by parsing source.

Remaining integration

P918 stays last behind accepted overlapping features: P957/P927/Core3566/ToAD1319, current P954/P958 corrections and other accepted consumers. Final imports must close on their actual combined tree. No pending feature source is manually ported here.

Core #3576 /ToAD #1313 were closed only after targeted delta comparison showed their migration work carried; all original branches/commits remain intact. No application obligation closed with those PRs.

Root owes current-head source review, one combined matched selection, schema/observation-key assessment and installed tool/member discovery plus saved-session concurrent-native-reply/fresh-DM/open-tab-return journey.

Assumed: the latest class-qualified wording instruction supersedes the earlier module-qualified contract; this source checkpoint is not final integration or runtime acceptance.

no handwritten name tag
AgentKindText already has a name

trissim commented Nov 1, 2026

Copy link
Copy Markdown
Author

Closing as superseded: toad main imports from the Core nominal owners since 100b7dc ("Import nominal declarations from agent_comms.nominal"), and its Core pair agent-comms #3614 is closed for the same reason (865135f71). Stale-backlog pass at Tristan's request.


Generated by Claude Code

@trissim trissim closed this Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant