Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Superseded by #1330 (ToAD 3d0ccc8), paired with OpenHCSDev/agent-comms#3614 (5936216f0). All old changed consumer paths and the active keymap reference are carried by the current pair; AgentKindText additionally retains its external schema wording through the ordered declaration-owned correction. Closing only the duplicate carrier, without deleting its branch or original 54f6ecc commits. No integration or runtime acceptance implied. |
Summary in numbers
P918 paired consumer of OpenHCSDev/agent-comms#3576: 2 commits, 91 files, +106/-106 (
git diff --stat origin/main...HEAD), 105 defining-module import sites including five nested imports, plus the active keymap plan's defining-class address. No UI, lifecycle, schema, model or delivery behavior is changed. Core moves four real module owners intoagent_comms.nominaland deletes their old paths; this PR points every actual ToAD production/test/support consumer at those owners.Base:
40bc104824c449f061f58b70d1b358c70535d000. Current paired checkpoint: Core100f036a9ed21fcd0692353b0731cdf313df439c, ToAD54f6ecca1175d71107d58ad1558d13a7b688ac5d. First published checkpoints remain Core27c136be6efe3a192e45ed58a91343d5c63ede86, ToADc3b1f71e817c2f31a09183fabbafa653c77021c1. Core owns the declaration move; ToAD must integrate with it, not ahead of it.Before / after
Before: ToAD imported DeclaredFamily, FieldCodec, field directives, nominal identities and representations from four flat Core module paths.
After: all consumers import the same declarations from their defining
agent_comms.nominalmodules. Function-local tool-output imports remain function-local. No reexport shim, second registry, codec adapter, compatibility reader or UI-side class mirror is added.Actual examples include
agent_schema.py,mcp_commands.py,mcp_inventory.py,tool_output.py,acp/sdk_boundary.py,db.py,keymap.py,widgets/comms_chat.py,widgets/transcript_fragments.pyand the native/model/textual/support consumers. The source receipt carries every exact path/site rather than another writable module roster.Evidence and limits
Retained map:
/home/ts/.cache/agent-scratch/checkout-caller/disposition-nominal-closure.json(5,662 file-cut observations; zero parse omissions). Current ToAD source patch:/home/ts/.cache/agent-scratch/package-declarations/relocation-source-evidence.json, using NRA ModuleSyntaxIndex and PythonModulePathIdentity; 90 actual files / 105 imports, zero selected parse omissions. No whole census/detector scan rerun.This is an authored source-import patch, not a native NRA module-relocation execution proof. The existing symbol movement operations do not cover the complete whole-module lifecycle, module-object bindings, embedded executable strings and defining-module effects of this move. No product imports or behavior execution are used to manufacture that proof.
Historical installed-source hashes/transcripts remain immutable observations. The active keymap plan's declaration reference now follows its actual owner. Arbitrary computed imports/reflection and external installed skill packages beyond the retained map remain OPEN, not silently counted as zero.
Required integration
Root's explicit sequence is accepted P883 carrying P872/Core #3566 + matched ToAD #1302 first; P904/Core #3572 follows that owner shape; retain Core #3574 DisclosureIdentity and #3575 performance/lifetime changes; P918 then resolves relocation across accepted current main before its final paired cut. Those branches are not manually ported here; accepted current mains are merged once and their imports are moved without deleting feature fields/callers. This source checkpoint is not acceptance of those unfinished features. Peer update bus36240 reports P883 source repair
6fba9a20bfe0139730c91fd946c2ff4105173073, ToAD #1302 carrieref21cbf251516e2ad486e38f3531fc50f4245786retaining435fd2e5e7d2f43005b334434067355f6467a468, and separate ToAD #1314 source configurationb1650dbada8fba182ad4abfbe25c292b8992f8cb. These are reported, unaccepted source cuts; no code from them is ported into this branch.Verification
No author tests, checkers, builds, providers, package sync or installed application run. Existing test imports are migrated only as consumers. Root owns one combined selection against the final paired heads and the real saved-session journey: tool discovery/member identity, concurrent native replies, fresh DM while its ToAD tab is open, reply/history/status and tab return. Core authors the cold-import identity/discovery/new-member controls; no parallel ToAD test system.
Assumed: paired integration/installation is ordered by root; this is not independently mergeable against the old Core defining-module paths.