Repository navigation
P448: qualify goals through the existing managed native workflow - #1135
Conversation
Native feedback qualification checkpointThe installed-afb three-case batch executed and failed all three cases (214.30s):
The shared direct/channel journeys now consume the existing owners instead of restating labels:
Focused Ruff, Python 3.14 compilation and Source inventory reused NRA Evidence: Separately, mi-1a's verify51b failed native preflight before UI ( Assumed: Core's declared progress capabilities and linked answer references, rather than historical English labels, are the qualification contract. This checkpoint fixes the test premise, not the unverified product workflow. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Goal qualification constructed an ACP server inside the test process, then handed Toad a detached agent with ready=True. That arrangement bypassed the managed native journey the cases were meant to qualify. The goal helper now enters the existing NativeSession; its provider, ACP connection, native owner and cleanup remain owned by the shared fixture. owner_server and the detached-agent setup are deleted.
The native cases retain goal creation reaching the provider, goal identity and stale-edit refusal, objective edits, failed-ledger repaint/productive successor and peer-mention navigation. The two remaining adapter consumers use bind_agent/agent_binding, and the native catalog declares accepts_comms_root.
Merged Toad main 67f6889 into this branch. The resulting diff is eight test/helper files: 120 additions, 125 deletions, and no production diff. Fifteen old PR file changes are redundant against main and have been removed.
Conflict resolutions:
Also removed auto-merged duplicate NoAgentBound imports in initial_prompt_handoff and key_bursts tests. No deleted initializer, older notification recomputation or local turn producer was restored.
Validation: refactor-audit Package AST inventory before/after covered all 23 original PR modules with zero parse omissions. Interpreter-imported all 23 actual modules, including the eight retained diff modules, using this Toad source and Core main 0e3c8f7f4. Existing runtime core-c2443b43c supplied Textual/UI dependencies; pytest was imported as a library from the existing Core development environment. The two script entry points were imported with their sibling directories available, as their real launches provide. All imports succeeded. owner_server has zero declarations/consumers. No pytest runs; the integrator runs behavior/native checks.
Assumed: main fixture owners remain authoritative; the integrator owns executing the native cases.