Skip to content

Make drivers report when earlier writes have finished - #90

Merged
trissim merged 3 commits into
mainfrom
refactor/driver-write-completion-20261007
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
refactor/driver-write-completion-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

Driver.call_after_flush is added: it flushes and then schedules a callback on the app's event loop, and does nothing if that loop is already closed. WriterThread.call_after_flush now takes the loop to deliver on, and _FlushSignal gets a deliver method that does the thread-safe scheduling. LinuxDriver, the web driver and the writer thread test are changed to match.

@trissim
trissim marked this pull request as ready for review October 7, 2026 07:02
Copilot AI balanced review requested due to automatic review settings October 7, 2026 07:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 6e950ba into main Oct 7, 2026
3 of 22 checks passed
@trissim trissim changed the title Make native drivers own write completion Make drivers report when earlier writes have finished Oct 11, 2026
@trissim
trissim deleted the refactor/driver-write-completion-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants