Skip to content

Use Textual's own flush callback for frame drawing - #513

Merged
trissim merged 3 commits into
mainfrom
evaluation/channel-send-live-hotpath-20261006
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
evaluation/channel-send-live-hotpath-20261006

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex work, mostly replaced. 2 of 13 code lines it added are still in main.

Remove the FrameFlush driver family from frame_presentation.py. The frame code now calls the driver's call_after_flush directly, relying on the Textual driver to run the callback after its write. Three small test and performance-tool files are updated to match.

@trissim
trissim marked this pull request as ready for review October 7, 2026 06:54
Copilot AI balanced review requested due to automatic review settings October 7, 2026 06:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit a84e392 into main Oct 7, 2026
2 checks passed
@trissim trissim changed the title Use native driver completion for frame publication Use Textual's own flush callback for frame drawing Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants