Skip to content

Compare a stored record's required keys as a set #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 29, 2026
Merged

Compare a stored record's required keys as a set #3621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d26c6a4
Compare a stored record's required keys as a set
trissim Oct 29, 2026
93ffe78
Let StoredForm own its required-key set at construction
trissim Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tools/stored_formats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ class StoredForm:

version: int
fields: dict[object, object]
required: list[str]
required: frozenset[str]
"""The keys every record carries: a set, because declaring a field in a parent class
reorders the schema's list without changing what is written."""

@classmethod
def of(cls, record: type) -> StoredForm | None:
Expand All @@ -39,6 +41,10 @@ def of(cls, record: type) -> StoredForm | None:
return cls(declared, properties, required)
return None

def __post_init__(self) -> None:
"""Each revision's probe prints the keys as a JSON list; their order means nothing."""
object.__setattr__(self, "required", frozenset(self.required))


def stored_formats(module_name: str) -> dict[str, StoredForm]:
module = importlib.import_module(module_name)
Expand All @@ -62,6 +68,7 @@ def main(modules: list[str]) -> None:
name: dataclasses.asdict(form)
for module in modules
for name, form in stored_formats(module).items()
}
},
default=sorted,
)
)
Loading