Repository navigation
Compare a stored record's required keys as a set - #3621
Merged
Merged
Conversation
UncarriedRecordFormat compared StoredForm.required as an ordered list, so declaring a field in a parent class (which reorders the schema's required list without changing what is written) counted as an uncarried format change. #3607 hit it on Thread. The required keys are a set: StoredForm owns that, and both revisions' probe output is read through from_wire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 29, 2026 22:07
|
debt-tools at c85517c, every finding: |
The previous head read the probe's JSON through from_wire with string subscripts, which the ratchet rightly counted. StoredForm's __post_init__ now turns whatever sequence it is given into the frozenset, the probe serializes it sorted, and the ratchet constructs it as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UncarriedRecordFormat (tools/debt_ratchet.py:2669) compared
StoredFormby dataclass equality, andrequiredwas a list, so reordering the required keys counted as a format change. Declaringname/created_atin a parent class reorders FieldCodec's schema list without changing a single stored byte. #3607 went red on exactly that for Thread.StoredForm.requiredis now afrozenset: the owner says the order means nothing.wire()/from_wire()are the one JSON boundary. The base revision's older probe still prints a list, andfrom_wirereads it as a set, so this works against current main bases immediately.Proof: real records from
agent_comms.active_routeround-trip equal, and equal again withrequiredreversed.🤖 Generated with Claude Code