Skip to content

Each side of the stored-format measure runs its own revision's reader #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Oct 29, 2026
Merged

Each side of the stored-format measure runs its own revision's reader #3593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tools/debt_ratchet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2606,7 +2606,7 @@ class UncarriedRecordFormat(ChangeMeasure):
"spec.loader.exec_module(module); "
"module.main(sys.argv[3:])"
)
"""This ratchet's reader, loaded by file, over only the revision's own source: a tools
"""The revision's own reader, loaded by file, over only the revision's own source: a tools
directory on the path would resolve the revision's bare imports into this one's tree."""

@staticmethod
Expand Down Expand Up @@ -2640,7 +2640,9 @@ def measured_formats(cls, repo: Path, ref: str, root: str,
if not modules:
return {}
with tempfile.TemporaryDirectory(prefix="debt-ratchet-formats-") as scratch:
source = git(repo, "archive", ref, "--", str(package))
# Each side runs its own revision's probe script: the head's may import modules
# that only the head's package declares (#3576 moved field_codec under nominal).
source = git(repo, "archive", ref, "--", str(package), "tools/stored_formats.py")
subprocess.run(["tar", "-x", "-C", scratch], input=source, check=True, timeout=60)
tree = Path(scratch)
sources = cls.source_paths(root, tree)
Expand All @@ -2650,7 +2652,7 @@ def measured_formats(cls, repo: Path, ref: str, root: str,
paths = dict.fromkeys((str(tree / package), *sources))
result = SpawnedProcess.run(
(sys.executable, "-c", cls.probe,
str(Path(__file__).resolve().with_name("stored_formats.py")),
str(tree / "tools/stored_formats.py"),
os.pathsep.join(paths), *modules), cwd=scratch,
env=cls.environment(root, tree), timeout=300,
)
Expand Down
Loading