Skip to content

Each side of the stored-format measure runs its own revision's reader - #3593

Merged
trissim merged 1 commit into
mainfrom
work/claude-code--formats-per-side
Oct 29, 2026
Merged

trissim merged 1 commit into
mainfrom
work/claude-code--formats-per-side

Conversation

@trissim

@trissim trissim commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

The stored-format measure runs each revision's own reader (1 commit, 1 file, +4/-2)

Bug. UncarriedRecordFormat.measured_formats (tools/debt_ratchet.py:2640-2660) archived each revision's package, but always ran the checkout's tools/stored_formats.py. A PR that moves an import inside that reader breaks the base side: #3576's reader imports agent_comms.nominal.field_codec, and main's package has no nominal. That is why debt-src and debt-tools crash on #3576 no matter how often it reruns.

Fix. tools/stored_formats.py is archived from the same revision as the package, and the probe runs that copy. Each side's reader matches its own package.

Proof. Same changed-module set (#3576's 40 changed src/agent_comms modules), installed runtime core-82c403efd:

Tools from Measuring origin/main Measuring #3576 head
#3576 (old behaviour) FAIL ModuleNotFoundError: No module named 'agent_comms.nominal' ok, 1 form
this PR, per-side reader ok, 1 form ok, 1 form
> ratchet measures main with tomorrow's reader
> reader asks main for a module main has never heard of
> crash, red on every run, for a week

🤖 Generated with Claude Code

https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK

The ratchet ran the checkout's tools/stored_formats.py against both
revisions' packages. #3576's reader imports agent_comms.nominal.field_codec,
which main's package does not have, so the base side crashed with
ModuleNotFoundError and debt-src/debt-tools went red on every run. The
reader is now archived with the revision's package and run from there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
Copilot AI balanced review requested due to automatic review settings October 29, 2026 06:34
@trissim
trissim enabled auto-merge October 29, 2026 06:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 94fcf27 Oct 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants