Skip to content

Test that judge reviewing withdraws an approved head's review status #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 25, 2026
Merged

Test that judge reviewing withdraws an approved head's review status #3217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f005a1
Withdraw the review status when a PR goes back or under review
trissim Oct 25, 2026
b3a4f58
Test that judge reviewing withdraws an accepted head's status
trissim Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_head_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,20 @@ def test_judge_ok_and_back_dispatch_orderless_prs_without_positional_edit_ids(he
assert len(tuple(call for call in github.calls() if f"statuses/{request.head}" in call[1])) == 2


def test_judge_reviewing_after_ok_withdraws_the_accepted_status_on_that_head(head_bus):
"""GitHub keeps the newest status per context on a commit, so reviewing an approved head
holds it out of the merge queue until a new ok."""
comms, github, request = head_bus
context = order.Commander.read_root(comms.root)
common = ["--repo", request.repo.to_wire(), "--pr", str(request.pr), "--head", request.head,
"--why", ACCEPTED.text]
judge.main(["ok", *common], context)
judge.main(["reviewing", *common], context)
posts = tuple(call for call in github.calls() if f"statuses/{request.head}" in call[1])
assert [next(part for part in post if part.startswith("state=")) for post in posts] == [
"state=success", "state=pending"]


def test_moved_head_posts_and_records_nothing(head_bus):
comms, github, request = head_bus
moved = replace(request, head="a" * 40)
Expand Down
Loading