Repository navigation
Reopened multiple inheritance phases: own-class isinstance and CLI failure roster become capabilities - #3195
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
… capabilities ThreadRows.__eq__ asked isinstance of its own class and fell back to Mapping equality; it now returns NotImplemented for anything but rows, the comparison guard shape. CLI_FAILURES listed CoordinationError and GitCommandError by hand; both now inherit the CommandFailure capability, which the tuple names once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
changed the title
Rows compare only to rows now; the test asked whether the document holds no thread rows, which is emptiness. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
marked this pull request as ready for review
October 25, 2026 02:31
trissim
enabled auto-merge
October 25, 2026 02:31
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple inheritance plan, batches 3 (
own_type_checks, plan_phases.py:596) and 4 (inheritance_cleanup, :603). Both read done on main a2333ca (10-23 21:40Z). Three later merges reopened them:registry_document.py:299isinstance(other, ThreadRows)cli_protocol.py:46CLI_FAILURES = (ValueError, OSError, CoordinationError, GitCommandError)field_codec.py:2382isinstance(data, NominalText)This PR:
ThreadRows.__eq__returnsNotImplementedfor anything that isn't rows (the comparison-guard shape), so it no longer falls back toMappingequality.CommandFailurein coordination_errors.py, besideDrainDeferred.CoordinationErrorandGitCommandErrorinherit it, andCLI_FAILURESnames(ValueError, OSError, CommandFailure). The builtins stay because they're foreign types.Touched tests: 205 passed across 14 files (the ThreadRows, CLI_FAILURES and GitCommandError consumers).
Evidence on this head: OwnClassChecksAbsent 1 site, field_codec.py:2382, which #3107 owns, so the
after=RedecodesDeletedPhasegate is real for exactly that one site. ParentsShared 0/11 short, RestatedMembersAbsent 0, flag probes 0, ClassRostersAbsent 0. Once #3107 lands, both phases read done.Assumed: nothing in src compares a
ThreadRowsto a plain dict (grepped every.threads ==). The one test that did,test_registration_components.py:41, now asserts emptiness. Every exception already caught byCLI_FAILURESis still caught, by the CoordinationError/GitCommandError MRO.🤖 Generated with Claude Code
https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V