Skip to content

Give the native import probe an owned package copy again #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 23, 2026
Merged

Give the native import probe an owned package copy again #2949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8cf4e2
Give the native import probe an owned package copy again
trissim Oct 23, 2026
f43505e
Check probe package ownership by real path and repin native inputs
trissim Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stack/pi-native.sha256
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ d64e8c05c7932d377034820b1db0df45612afe64885c0765f8f348a12e1bc955 dist/core/skil
0391543cf703a93a0163b37b3ccebe53e0f12bff6f6162b86d56fb017fe49011 dist/core/system-prompt.js
# agent-comms-native-stock-v1 @earendil-works/pi-coding-agent@0.85.1
# agent-comms-native-tree-v1 17edf8badd73bafccf592b651b5a9c0f71b2b05b89db470d1042d3ccb544a0b9
# agent-comms-native-inputs-v1 eb243f7053a9983fd735cb0d98c6c89ef674052403ef5ea3a41bb3426406df17
# agent-comms-native-inputs-v1 98ae7ef97dd2811949ed3877038887d95c043f8b078331746bc1f8587645bcbc
11 changes: 7 additions & 4 deletions stack/test-native-import-rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def ancestor_probe(
package: Path, root: Path, env: dict[str, str], deny: Callable[[], None]
) -> dict:
"""Admit real PR77, then reach a committed ws entry's optional ancestor require."""
assert package.is_relative_to(root), "Owned fixture package required"
assert package.resolve().is_relative_to(root.resolve()), "Owned fixture package required"
ancestor = package.parent.parent / "bufferutil"
ancestor.mkdir(mode=0o700) # Exclusive: never replace an existing dependency.
marker = root / "ancestor-executed"
Expand Down Expand Up @@ -340,6 +340,9 @@ def main(launch: VerifiedNativePackage, root: Path) -> None:
with tempfile.TemporaryDirectory(prefix="native-import-rpc-") as directory:
root = Path(directory)
prepared = pinned_native_package()
native_root = root / prepared.parents[2].name
native_root.symlink_to(prepared.parents[2], target_is_directory=True)
main(VerifiedNativePackage.qualify(native_root / PACKAGE_LAYOUT), root)
# Node resolves modules by realpath, so a link would put every ancestor of the
# probed ws entry back in the shared store; only an owned copy has owned ancestors.
package = root / prepared.parents[2].name / PACKAGE_LAYOUT
package.parent.mkdir(parents=True, mode=0o700)
shutil.copytree(prepared, package)
main(VerifiedNativePackage.qualify(package), root)
Loading