[trissim]

native-scripts has failed on every merge to main since #2873 (15:42 on 10-23; #2883 at 15:40 passed). The failure is stack/test-native-import-rpc.py:124, seen == [].

Cause. 7a51a47 (merged in #2873) replaced the probe's private package copy with a symlink into the shared native store (stack/test-native-import-rpc.py:344). Node resolves modules by their realpath. So the parentURL of the probed ws/lib/buffer-util.js became the store path, while the probe compares it with the lexical link path (requiringModule from argv[4], line 85). The fence still refused bufferutil, but the comparison filtered the refusal out.

The symlink also broke ownership. ancestor.mkdir at line 56 planted bufferutil inside the shared store's node_modules for the length of the run. The is_relative_to(root) guard at line 54 checks only the lexical path, so it passed anyway.

Fix. Copy the prepared package into the temporary root again, so every ancestor of the probed entry is owned. TemporaryDirectory reaps the sealed copy. Before 7a51a47, the copy was removed by remove_native_tree. That commit deleted the function from native_package.py, so it no longer exists on main, and this PR does not bring it back. qualify checks only layout and seal, so it accepts the copy.

The ownership guard at line 54 now compares real paths (package.resolve().is_relative_to(root.resolve())). A package symlinked under root therefore fails the guard before the probe can plant or remove bufferutil in a shared tree (IDEN-7: the guard checked the spelled path, but the fact it needs is where the package really lives).

The test is a native build input (native_build_inputs.py:35 inventories every stack/*.py), so the manifest's inputs pin is regenerated with stack/bin/prepare-pi-native --update-pins.

Proof (local, Node 26.4.0, the workflow's command under the Core runtime):

• before, on main 7eefe39: AssertionError: {'factory': 'function', ..., 'seen': []}, rc 1. This is the same assertion as hosted run 40032749628, so the failure does not depend on the environment.
• after: rc 0, "seen": [{"code": "ERR_NATIVE_IMPORT_BOUNDARY", "parent": "file:///tmp/native-import-rpc-.../ws/lib/buffer-util.js"}]. No /tmp/native-import-rpc-* dir is left behind.

Assumed:

• Copying 192M into the temporary root per run is acceptable, as it was before 7a51a47. Hardlinks cannot cross into a tmpfs /tmp.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.