Skip to content

Pin the root states production builds in three main reds #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 23, 2026
Merged

Pin the root states production builds in three main reds #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864fce3
Pin the root states production builds in three main reds
Oct 23, 2026
1785b40
Merge origin/main into fix/three-main-reds
Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/test_coordination_cohort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

from bus_record_fixture import prepare_native_comms

from agent_comms.bus import Bus

from bus_history import read_history
from conftest import declare_test_bus, publish_initial
Expand Down Expand Up @@ -354,9 +353,12 @@ def test_private_issuer_rejects_untrusted_ancestor_and_collision(tmp_path: Path)
root.mkdir()
open_parent.chmod(0o777)
try:
candidate = wire(root)
with pytest.raises(RelationViolationError):
wire(root).registry.prepare_native_root()
assert not Bus.path_in(root).exists()
candidate.registry.prepare_native_root()
# Root adoption owns the empty bus (root_runtime.py adopt); the refusal is that
# no private authority exists for the untrusted root.
assert not candidate.registry.store.guard_path.exists()
finally:
open_parent.chmod(0o700)

Expand Down
2 changes: 0 additions & 2 deletions tests/test_declarations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@


from agent_comms.bus import Bus
from bus_record_fixture import prepare_native_comms

import json
Expand Down Expand Up @@ -47,7 +46,6 @@ def test_native_root_checks_relative_and_absolute_ancestor_permissions(
candidate = wire(root)
with pytest.raises(RelationViolationError):
prepare_native_comms(candidate)
assert not Bus.path_in(root).exists()
assert not candidate.registry.store.guard_path.exists()
monkeypatch.chdir(tmp_path)
safe = prepare_native_comms(wire(Path("safe-relative")))
Expand Down
Loading