Repository navigation
Pin the root states production builds in three main reds - #2881
Merged
Merged
Conversation
test_native_root_checks_relative_and_absolute_ancestor_permissions and test_private_issuer_rejects_untrusted_ancestor_and_collision turned red at 4ab345b (#2854): root adoption now creates every root's empty bus (root_runtime.py adopt), and wire() adopts, so a bus exists before prepare_native_root refuses the untrusted ancestor. Both tests still asserted the old creation owner (bus created at native prepare). The invariant they exist for is that a refused root gains no private authority: both now assert the registry guard is never created. test_newer_read_moves_past_a_line_still_being_appended installed PrivateCoordinatorTable on a bare wire() root with no registry guard, a state registry_store.py:357-360 refuses ("Native runtime has no registry authority"). It now builds on private_comms, whose prepare_native_root is the one production owner of the private runtime, as #2872 did for nine other tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
marked this pull request as ready for review
October 23, 2026 19:18
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_native_root_checks_relative_and_absolute_ancestor_permissions and
test_private_issuer_rejects_untrusted_ancestor_and_collision turned red at
4ab345b (#2854): root adoption now creates every root's empty bus
(root_runtime.py adopt), and wire() adopts, so a bus exists before
prepare_native_root refuses the untrusted ancestor. Both tests still
asserted the old creation owner (bus created at native prepare). The
invariant they exist for is that a refused root gains no private
authority: both now assert the registry guard is never created.
test_newer_read_moves_past_a_line_still_being_appended installed
PrivateCoordinatorTable on a bare wire() root with no registry guard, a
state registry_store.py:357-360 refuses ("Native runtime has no registry
authority"). It now builds on private_comms, whose prepare_native_root is
the one production owner of the private runtime, as #2872 did for nine
other tests.
Tests: the three files at the head, 71 passed, 1 skipped, under a 0700 basetemp.
🤖 Generated with Claude Code