Skip to content

Let the SessionStart owner test give its root to the runtime that serves it #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Oct 23, 2026
Merged

Let the SessionStart owner test give its root to the runtime that serves it #2857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/test_session_bridge_owner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
"""The real SessionStart program must leave an installable serve after hook exit."""


from agent_comms.bus import Bus

import asyncio
import json
import os
Expand All @@ -20,6 +17,7 @@
from agent_comms.cli_bridges.shared import Binding, Serve
from agent_comms.comms import wire
from agent_comms.launch_runtime import LaunchRuntime
from agent_comms.root_runtime import RootRuntime
from agent_comms.thread_execution import ExternalThreadExecution
from agent_comms_hooks.session import started
from agent_comms_hooks.watch import LiveWatch, WatchClaim, WatchRecord
Expand All @@ -31,7 +29,8 @@ def test_session_start_hook_exit_preserves_the_recorded_owner_for_install_pause(
home = bridge_home
session = 'copied-session'
comms = wire(tmp_path / 'bus')
Bus.install(Bus.path_in(comms.root))
# The source programs run the hook's bridge, so their runtime owns the root it attaches to.
RootRuntime.publish(comms.root, source_programs.runtime)
comms.registry.declare(Thread(
'bridge-copy', frozenset(), str(tmp_path), execution=ExternalThreadExecution))
transcript = tmp_path / f'{session}.jsonl'
Expand Down Expand Up @@ -92,7 +91,7 @@ def unexpected_serve():
assert observed.process.alive()
(bridge,) = Serve.running(home)
with ExitStack() as resources:
(paused,) = bridge.pause(resources)
paused = bridge.pause(resources)
assert paused.bridge.observed.owner == expected
assert isinstance(claim.state(), LiveWatch)
assert owner.poll() is None
Expand Down
Loading