Repository navigation
Let the SessionStart owner test give its root to the runtime that serves it - #2857
Merged
Merged
Conversation
…ves it The test built its root in-process, so the test venv adopted it, then started the hook's bridge from the source programs: RootRuntime refused that foreign runtime and the bridge died before readiness. Publish the root to the source programs' runtime, as test_install_session_bridge and test_goal_nominal do, and drop the Bus.install that root adoption already performs. SessionBridge.pause returns one ResumableBridge, so stop unpacking it as a tuple. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red on
test_session_start_hook_exit_preserves_the_recorded_owner_for_install_pausesince before 55d5a3e. Nobody owned it.Why it failed (two stale facts in the test):
wire(), so the test venv's runtime adopted it. The hook's bridge then ran from the source programs,RootRuntime.require_attachablerefused it withForeignRuntimeError, and the bridge died before readiness. The test reported "Session bridge startup not observed". Its siblings (test_install_session_bridge.py:42,test_goal_nominal.py:121) publish the root to the serving runtime. This one now does too.SessionBridge.pausereturns a singleResumableBridge(shared.py:652). The test still unpacked it as a 1-tuple.The
Bus.installline is deleted because root adoption creates the bus (root_runtime.py:69, #2854).#2854did not cause this: it failed the same way on 55d5a3e, before #2854 landed.Proof:
tests/test_session_bridge_owner.py, 1 passed, at this head on main 4ab345b.🤖 Generated with Claude Code