Repository navigation
KindFamilies: put kind behavior and spelling on declared cases - #2667
Merged
4 commits merged intoOct 23, 2026
Merged
4 commits merged into
4 commits merged into
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 08:18
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-tools at ba056fa, every finding: |
|
debt-src at ba056fa, every finding: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six kind encodings now carry their behavior on declared cases. 350 lines deleted, 435 added at fa87d28.
Removed production decision/restatement sites, at base c613c0f: channel_management.py:122 (TagAction match); execution_store.py:77 and :79 (wire/claimless creation); coordination_tables/executions.py:236 (retry); coordination_snapshot.py:211 (route switch); cohort_schema.py:342 (obligation origin); turn_inputs.py:37 and :170 (parallel Pi dispatch); messages.py:278 (control flag); channels.py:197 (membership case selection). SQL wire identities at coordination_tables/executions.py:182, :207, :335 and :339 and coordination_tables/responses.py:65 and :76 now derive from WireOrigin's methods. Old enum normalization in executions.py:277 is deleted. No production caller compares these cases to choose their behavior.
The phase's ViewKind name check previously also banned typed_table.ViewKind(CatalogKind), an already-correct behavior owner for SQLite schema-table type=view. Keep it exact and restrict that evidence to the actual bare-enum ViewKind. SQLite owns that catalog vocabulary. Pi's native RPC streamingBehavior owns steer/followUp; those bytes remain exact on the case declarations. No compatibility aliases or alternate decoding path.
The existing tests/fixtures and tool-schema expectations are migrated with the source. The tag tool's canonical request is now edit={kind:create,name:...}; native tool schemas supply that shape. Membership and saved-view stored wire keys retain their existing spellings. SQL generated columns retain the scalar predicate with the present single sourced case; retry-view/trigger text now derives its predicate from the owner.
The pre-edit NRA receipt covers762 Core/paired-Toad/dependency modules and6410 original classes, with8 unprojected local/conditional declarations explicitly OPEN; lexical matches do not establish arbitrary dynamic binding. Receipt: /home/ts/.cache/agent-scratch/commander-control-plane/kind-families-source-before.json. No later census, debt scan or test run was made after Tristan stopped worker checks. The single integrator owns the changed test files and actual application checks.
Shared-file boundaries: tools.py contains only tag/view type changes; publisher.py and response_conversation.py replace ordinary-control references; plan_phases.py changes only KindFamilies evidence. MI field names and ControlPlane/relocation behavior remain with their respective owners.
Assumed: runtime origins use the nominal cases; Pi retains its pinned streamingBehavior contract; the integrator combines the shared-file heads and runs the changed tests once. Source shape alone is not installed qualification. OwnedDispatch follows on a fresh main branch.